Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x][BUG]fix suggestion list cutoff issue #2646

Merged

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Oct 21, 2022

In this PR, we fixed the suggestion list cutoff in an easy way. We remove width 250px and add block display to allow browser to select a width and add ellipsis at the bottom.

However, we might have longer input that can't fit into the search. When we truncate the search, the elements look the same which might be still an issue for customer usage. We definitely need more feedbacks on the cutoff behavior.

Issue resolved:
#2555

Backport PR:
#2607

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh ananzh requested a review from a team October 21, 2022 20:52
@ananzh ananzh changed the title [backport-1.x][BUG]fix suggestion list cutoff issue [Backport-1.x][BUG]fix suggestion list cutoff issue Oct 21, 2022
@ananzh ananzh changed the title [Backport-1.x][BUG]fix suggestion list cutoff issue [Backport 1.x][BUG]fix suggestion list cutoff issue Oct 21, 2022
In this PR, we fixed the suggestion list cutoff in an easy way.
We remove width 250px and add block display to allow browser to
select a width and add ellipsis at the bottom.

However, we might have longer input that can't fit into the search.
When we truncate the search, the elements look the same which might
be still an issue for customer usage. We definitely need more
feedbacks on the cutoff behavior.

Issue resolved:
opensearch-project#2555

Backport PR:
opensearch-project#2607

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh force-pushed the backport-1.x-fix-suggestion-cutoff branch from 78712fe to 95489db Compare October 21, 2022 20:53
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport/backport-2646-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ba3e01fc5d459aa8e0e047fbc84f3f9049645c92
# Push it to GitHub
git push --set-upstream origin backport/backport-2646-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2

Then, create a pull request where the base branch is 1.2 and the compare/head branch is backport/backport-2646-to-1.2.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 31, 2022
In this PR, we fixed the suggestion list cutoff in an easy way.
We remove width 250px and add block display to allow browser to
select a width and add ellipsis at the bottom.

However, we might have longer input that can't fit into the search.
When we truncate the search, the elements look the same which might
be still an issue for customer usage. We definitely need more
feedbacks on the cutoff behavior.

Issue resolved:
#2555

Backport PR:
#2607

Signed-off-by: Anan Zhuang <[email protected]>

Signed-off-by: Anan Zhuang <[email protected]>
(cherry picked from commit ba3e01f)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.1 1.1
# Navigate to the new working tree
cd .worktrees/backport-1.1
# Create a new branch
git switch --create backport/backport-2646-to-1.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ba3e01fc5d459aa8e0e047fbc84f3f9049645c92
# Push it to GitHub
git push --set-upstream origin backport/backport-2646-to-1.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.1

Then, create a pull request where the base branch is 1.1 and the compare/head branch is backport/backport-2646-to-1.1.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0 1.0
# Navigate to the new working tree
cd .worktrees/backport-1.0
# Create a new branch
git switch --create backport/backport-2646-to-1.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ba3e01fc5d459aa8e0e047fbc84f3f9049645c92
# Push it to GitHub
git push --set-upstream origin backport/backport-2646-to-1.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0

Then, create a pull request where the base branch is 1.0 and the compare/head branch is backport/backport-2646-to-1.0.

joshuarrrr pushed a commit that referenced this pull request Nov 1, 2022
In this PR, we fixed the suggestion list cutoff in an easy way.
We remove width 250px and add block display to allow browser to
select a width and add ellipsis at the bottom.

However, we might have longer input that can't fit into the search.
When we truncate the search, the elements look the same which might
be still an issue for customer usage. We definitely need more
feedbacks on the cutoff behavior.

Issue resolved:
#2555

Backport PR:
#2607

Signed-off-by: Anan Zhuang <[email protected]>

Signed-off-by: Anan Zhuang <[email protected]>
(cherry picked from commit ba3e01f)

Co-authored-by: Anan Zhuang <[email protected]>
@ananzh ananzh added the v1.3.7 label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants