Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [MD] Feature test connection #3067

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 75df251 from #2973.

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner December 13, 2022 01:31
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022

Codecov Report

Merging #3067 (28a4bd1) into 2.x (0a92e60) will decrease coverage by 0.04%.
The diff coverage is 68.65%.

@@            Coverage Diff             @@
##              2.x    #3067      +/-   ##
==========================================
- Coverage   66.67%   66.63%   -0.05%     
==========================================
  Files        3219     3219              
  Lines       61450    61504      +54     
  Branches     9417     9430      +13     
==========================================
+ Hits        40971    40981      +10     
- Misses      18232    18279      +47     
+ Partials     2247     2244       -3     
Flag Coverage Δ
Linux 66.63% <68.65%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/plugins/data_source/server/client/client_pool.ts 58.82% <ø> (ø)
...gins/data_source/server/client/configure_client.ts 63.63% <31.81%> (-23.55%) ⬇️
.../plugins/data_source/server/data_source_service.ts 71.42% <66.66%> (-3.58%) ⬇️
...ents/edit_data_source/components/header/header.tsx 93.75% <75.00%> (-6.25%) ⬇️
.../data_source_management/public/components/utils.ts 95.83% <75.00%> (-4.17%) ⬇️
...components/create_form/create_data_source_form.tsx 96.96% <83.33%> (-1.40%) ⬇️
...rce/components/edit_form/edit_data_source_form.tsx 90.76% <86.66%> (-0.69%) ⬇️
...e_data_source_wizard/create_data_source_wizard.tsx 97.50% <100.00%> (+0.72%) ⬆️
...c/components/edit_data_source/edit_data_source.tsx 88.23% <100.00%> (+0.48%) ⬆️
...ta_source/server/legacy/configure_legacy_client.ts 10.41% <0.00%> (-60.42%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr added the autocut Skip the changelog verification check on backports label Dec 15, 2022
@joshuarrrr joshuarrrr added the v2.5.0 'Issues and PRs related to version v2.5.0' label Dec 23, 2022
* test connection intial code

Signed-off-by: mpabba3003 <[email protected]>

* error handling

Signed-off-by: mpabba3003 <[email protected]>

* refactor

Signed-off-by: mpabba3003 <[email protected]>

* removing get cluster info dependency

Signed-off-by: mpabba3003 <[email protected]>

* refactor test connection

Signed-off-by: mpabba3003 <[email protected]>

* adding test cases and test connection on edit datasource

Signed-off-by: mpabba3003 <[email protected]>

* adding changelog comment

Signed-off-by: mpabba3003 <[email protected]>

* fixing bug on edit datasource page

Signed-off-by: mpabba3003 <[email protected]>

* refactor based on PR comments

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
(cherry picked from commit 75df251)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@joshuarrrr joshuarrrr force-pushed the backport/backport-2973-to-2.x branch from bfaf23e to 28a4bd1 Compare December 28, 2022 21:23
@kavilla kavilla merged commit 201c228 into 2.x Jan 3, 2023
@github-actions github-actions bot deleted the backport/backport-2973-to-2.x branch January 3, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants