[CCI] Fix type errors in Saved Object Management #3987

Nicksqain · 2023-05-06T08:38:46Z

Description

Issues Resolved

closes Fix type errors from Saved Object Management changes #3023

Check List

Signed-off-by: Alexei Karikov <[email protected]>

Nicksqain · 2023-05-06T08:41:20Z

I've fixed most of the errors, could you check? Could you suggest how best to fix the errors in

src\plugins\saved_objects_management\server\routes\scroll_count.ts

joshuarrrr · 2023-05-12T21:07:01Z

@Nicksqain Some of the unit test snapshots need to be updated. You can do that via yarn test:jest -u. See failures: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/4900693983/jobs/8751525045?pr=3987

Signed-off-by: Alexei Karikov <[email protected]>

Nicksqain · 2023-05-13T11:12:31Z

@Nicksqain Some of the unit test snapshots need to be updated. You can do that via yarn test:jest -u. See failures: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/4900693983/jobs/8751525045?pr=3987

I have updated the snapshot, which should solve the problem

Signed-off-by: Alexei Karikov <[email protected]>

Nicksqain · 2023-05-13T11:48:36Z

...lugins/saved_objects_management/public/management_section/objects_table/components/table.tsx

  onTableChange: (table: any) => void;
  isSearching: boolean;
  onShowRelationships: (object: SavedObjectWithMetadata) => void;
  canGoInApp: (obj: SavedObjectWithMetadata) => boolean;
-  dateFormat: string;
+  dateFormat?: string;


I'm not sure about the optional dateFormat props because it's not used in the defaultProps

src\plugins\saved_objects_management\public\management_section\objects_table\components\table.test.tsx test

I think making it optional is probably fine - moment will accept undefined as an input on L251. Alternatively you could just update the test defaultProps to include it, like in

OpenSearch-Dashboards/src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx

Line 164 in 07e9773

dateFormat: 'YYYY-MM-DD',

Nicksqain · 2023-05-13T11:57:25Z

...aved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx

@@ -161,6 +161,7 @@ describe('SavedObjectsTable', () => {
      goInspectObject: () => {},
      canGoInApp: () => true,
      search,
+      dateFormat: 'YYYY-MM-DD',


Can you tell me what value the dateFormat should take? In

src\plugins\saved_objects_management\public\management_section\saved_objects_table_page.tsx

the value is

const dateFormat = coreStart.uiSettings.get<string>('dateFormat');

That's a good question. It's a little hard to tell, but to be consistent with the ui_settings test, I'd use Browser as the default test string:

OpenSearch-Dashboards/src/core/public/ui_settings/ui_settings_client.test.ts

Line 39 in d7004dc

const { defaults = { dateFormat: { value: 'Browser' } }, initialSettings = {} } = options;

codecov · 2023-05-13T12:08:51Z

Codecov Report

Merging #3987 (025d6e1) into main (5c5de03) will decrease coverage by 0.06%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #3987      +/-   ##
==========================================
- Coverage   66.36%   66.30%   -0.06%     
==========================================
  Files        3229     3229              
  Lines       62145    62147       +2     
  Branches     9622     9623       +1     
==========================================
- Hits        41240    41205      -35     
- Misses      18584    18615      +31     
- Partials     2321     2327       +6

Flag	Coverage Δ
Linux	`?`
Windows	`66.30% <33.33%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...objects_management/public/lib/get_relationships.ts	`75.00% <ø> (ø)`
...saved_objects_management/public/lib/parse_query.ts	`88.88% <ø> (ø)`
...agement_section/objects_table/components/table.tsx	`64.91% <ø> (ø)`
...ins/saved_objects_management/server/routes/find.ts	`6.66% <0.00%> (-0.23%)`	⬇️
...d_objects_management/server/routes/scroll_count.ts	`6.25% <0.00%> (ø)`
...ment_section/objects_table/saved_objects_table.tsx	`67.98% <33.33%> (ø)`
...ts_management/public/services/namespace_service.ts	`25.00% <100.00%> (+6.81%)`	⬆️

... and 7 files with indirect coverage changes

Signed-off-by: Josh Romero <[email protected]>

joshuarrrr · 2023-06-06T19:31:56Z

(I resolved CHANGELOG conflicts)

joshuarrrr

Mostly looking good, a couple minor questions.

joshuarrrr · 2023-06-06T19:32:46Z

src/plugins/saved_objects_management/public/lib/get_relationships.ts

+  } catch (respError: any) {
    const respBody = get(respError, 'data', {}) as any;


nit - in general, prefer unknown to any.

joshuarrrr · 2023-06-06T19:35:51Z

src/plugins/saved_objects_management/public/services/namespace_service.ts

-  private readonly alias;
+  private alias: string = '';


This changes the behavior a bit. Is there any error cases or edge case handling that needs to be changed to handle '' vs undefined as the default value?

zhongnansu

PR lgtm. There's a snapshot test failed from CI. Can you update snapshots?

zhongnansu · 2024-05-29T03:01:44Z

PR has been stale for 10 months. Closing. Feel free to re-open if you plan to work on it again. @Nicksqain
cc: @abbyhu2000

Nicksqain added 4 commits May 6, 2023 14:15

fix ts errors in parse query

9a2073f

Signed-off-by: Alexei Karikov <[email protected]>

fix ts errors in table

7109ac1

Signed-off-by: Alexei Karikov <[email protected]>

fix ts errors with namespace

f5b6f43

Signed-off-by: Alexei Karikov <[email protected]>

fix ts errors with tests

67ea995

Signed-off-by: Alexei Karikov <[email protected]>

Nicksqain requested review from ananzh, kavilla, seanneumann, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu and manasvinibs as code owners May 6, 2023 08:38

github-actions bot added the repeat-contributor label May 6, 2023

joshuarrrr added the OSCI Open Source Contributor Initiative label May 12, 2023

Nicksqain added 3 commits May 13, 2023 16:56

Update snapshot by adding namespaceRegistry

db883c8

Signed-off-by: Alexei Karikov <[email protected]>

Merge branch 'main' into fix-type-errors-SOM-changes

b3730a4

Add changelog entry

754d764

Signed-off-by: Alexei Karikov <[email protected]>

Nicksqain added 2 commits May 13, 2023 17:26

Add dateFormat prop

07e9773

Signed-off-by: Alexei Karikov <[email protected]>

Add Counts interface

fd0ffb3

Signed-off-by: Alexei Karikov <[email protected]>

Nicksqain commented May 13, 2023

View reviewed changes

abbyhu2000 assigned zhongnansu May 16, 2023

SergeyMyssak mentioned this pull request May 20, 2023

[Research] [CCI] OUI Usage Audit in saved_objects_management plugin #3967

Open

joshuarrrr changed the title ~~[CCI] Fix type errors som changes~~ [CCI] Fix type errors in Saved Object Management Jun 6, 2023

Merge branch 'main' into fix-type-errors-SOM-changes

025d6e1

Signed-off-by: Josh Romero <[email protected]>

joshuarrrr requested review from ZilongX and Flyingliuhub as code owners June 6, 2023 19:31

joshuarrrr reviewed Jun 6, 2023

View reviewed changes

zhongnansu reviewed Jun 7, 2023

View reviewed changes

joshuarrrr added the needs more info Requires more information from poster label Jun 20, 2023

abbyhu2000 marked this pull request as draft July 25, 2023 19:12

zhongnansu closed this May 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CCI] Fix type errors in Saved Object Management #3987

[CCI] Fix type errors in Saved Object Management #3987

Nicksqain commented May 6, 2023

Nicksqain commented May 6, 2023

joshuarrrr commented May 12, 2023

Nicksqain commented May 13, 2023

Nicksqain May 13, 2023 •

edited

Loading

joshuarrrr Jun 6, 2023

Nicksqain May 13, 2023

joshuarrrr Jun 6, 2023

codecov bot commented May 13, 2023 •

edited

Loading

joshuarrrr commented Jun 6, 2023

joshuarrrr left a comment

joshuarrrr Jun 6, 2023

joshuarrrr Jun 6, 2023

zhongnansu left a comment

zhongnansu commented May 29, 2024

		} catch (respError: any) {
		const respBody = get(respError, 'data', {}) as any;

[CCI] Fix type errors in Saved Object Management #3987

[CCI] Fix type errors in Saved Object Management #3987

Conversation

Nicksqain commented May 6, 2023

Description

Issues Resolved

Check List

Nicksqain commented May 6, 2023

joshuarrrr commented May 12, 2023

Nicksqain commented May 13, 2023

Nicksqain May 13, 2023 • edited Loading

Choose a reason for hiding this comment

joshuarrrr Jun 6, 2023

Choose a reason for hiding this comment

Nicksqain May 13, 2023

Choose a reason for hiding this comment

joshuarrrr Jun 6, 2023

Choose a reason for hiding this comment

codecov bot commented May 13, 2023 • edited Loading

Codecov Report

joshuarrrr commented Jun 6, 2023

joshuarrrr left a comment

Choose a reason for hiding this comment

joshuarrrr Jun 6, 2023

Choose a reason for hiding this comment

joshuarrrr Jun 6, 2023

Choose a reason for hiding this comment

zhongnansu left a comment

Choose a reason for hiding this comment

zhongnansu commented May 29, 2024

Nicksqain May 13, 2023 •

edited

Loading

codecov bot commented May 13, 2023 •

edited

Loading