Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard De-Angular] Use React to start up dashboard plugin and configure react routing #4012

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented May 11, 2023

Description

This PR removes the current angular code in the dashboard plugin, and set up basic react components and react routing to start up the dashboard plugin.

Expected behabior:

  • Dashboard plugin is able to start up without using Angular, but using react framework.
  • Basic routing works:
    • '/' or 'listing' will go to dashboard listing page
    • 'create' or 'view/:id' will go to dashboard editor page
    • others will go to no match page
  • Will revisit routing in later PRs to add more routing related configurations.
Screen.Recording.2023-05-11.at.5.42.18.PM.mov

Issues Resolved

resolves #3999

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Use React to start up the dashboard app, and use react routing to configure basic
routing for dashboard plugin.

Signed-off-by: abbyhu2000 <[email protected]>
@abbyhu2000 abbyhu2000 force-pushed the deangular/replace-start-and-router branch from 1776e6e to 1478077 Compare May 11, 2023 23:34
Will revisit when the proper state management is added.

Signed-off-by: abbyhu2000 <[email protected]>
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #4012 (2db1f8b) into feature/deangular-dashboards (0188d05) will increase coverage by 0.09%.
The diff coverage is 31.57%.

@@                       Coverage Diff                        @@
##           feature/deangular-dashboards    #4012      +/-   ##
================================================================
+ Coverage                         66.44%   66.53%   +0.09%     
================================================================
  Files                              3229     3230       +1     
  Lines                             62067    61898     -169     
  Branches                           9599     9560      -39     
================================================================
- Hits                              41238    41184      -54     
+ Misses                            18526    18421     -105     
+ Partials                           2303     2293      -10     
Flag Coverage Δ
Linux 66.48% <31.57%> (+0.09%) ⬆️
Windows 66.48% <31.57%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/dashboard/public/plugin.tsx 0.00% <0.00%> (ø)
src/plugins/dashboard/public/application/index.tsx 20.00% <20.00%> (ø)
src/plugins/dashboard/public/application/app.tsx 50.00% <50.00%> (ø)
...public/application/components/dashboard_editor.tsx 50.00% <50.00%> (ø)
...ublic/application/components/dashboard_listing.tsx 50.00% <50.00%> (ø)
...blic/application/components/dashboard_no_match.tsx 50.00% <50.00%> (ø)
...ublic/application/components/dashboard_top_nav.tsx 50.00% <50.00%> (ø)

... and 10 files with indirect coverage changes

@abbyhu2000 abbyhu2000 assigned joshuarrrr and kavilla and unassigned joshuarrrr May 12, 2023
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine for initial de-angular for feature branch. would like to unblock the progress.

@ananzh ananzh merged commit c85cd44 into opensearch-project:feature/deangular-dashboards May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants