Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Vis Augmenter Add UT for few fns #4534

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1dc1060 from #4516.

* Add UT for few fns

Signed-off-by: Tyler Ohlsen <[email protected]>

* add changelog entry

Signed-off-by: Tyler Ohlsen <[email protected]>

---------

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 1dc1060)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #4534 (5a8068d) into 2.x (a287203) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              2.x    #4534      +/-   ##
==========================================
+ Coverage   66.44%   66.50%   +0.06%     
==========================================
  Files        3287     3287              
  Lines       63286    63282       -4     
  Branches     9846     9846              
==========================================
+ Hits        42049    42088      +39     
+ Misses      18857    18815      -42     
+ Partials     2380     2379       -1     
Flag Coverage Δ
Linux 66.43% <100.00%> (+0.04%) ⬆️
Windows 66.46% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/vis_augmenter/public/vega/helpers.ts 98.50% <ø> (+19.83%) ⬆️
src/plugins/vis_augmenter/public/utils/utils.ts 96.55% <100.00%> (+6.55%) ⬆️

... and 1 file with indirect coverage changes

@manasvinibs
Copy link
Member

@ohltyler Can you pls check the CI check failure related to functional test ciGroup10 before we merge this one?

@ananzh ananzh merged commit 4f0a575 into 2.x Jul 11, 2023
@github-actions github-actions bot deleted the backport/backport-4516-to-2.x branch July 11, 2023 18:01
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 11, 2023
* Add UT for few fns
* add changelog entry

---------

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 1dc1060)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 4f0a575)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla pushed a commit that referenced this pull request Jul 11, 2023
* Add UT for few fns
* add changelog entry

---------


(cherry picked from commit 1dc1060)



(cherry picked from commit 4f0a575)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports feature-anywhere v2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants