-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Vis Augmenter Add UT for few fns #4534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add UT for few fns Signed-off-by: Tyler Ohlsen <[email protected]> * add changelog entry Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 1dc1060) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Codecov Report
@@ Coverage Diff @@
## 2.x #4534 +/- ##
==========================================
+ Coverage 66.44% 66.50% +0.06%
==========================================
Files 3287 3287
Lines 63286 63282 -4
Branches 9846 9846
==========================================
+ Hits 42049 42088 +39
+ Misses 18857 18815 -42
+ Partials 2380 2379 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@ohltyler Can you pls check the CI check failure related to functional test ciGroup10 before we merge this one? |
manasvinibs
approved these changes
Jul 11, 2023
ananzh
approved these changes
Jul 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Add UT for few fns * add changelog entry --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 1dc1060) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 4f0a575) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
all-star-contributor
autocut
Skip the changelog verification check on backports
feature-anywhere
v2.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1dc1060 from #4516.