[Data Explorer] Merging main to feature branch #4691

ashwin-pc · 2023-08-07T20:35:35Z

Description

Merges main into data explorer feature branch

Issues Resolved

Screenshot

Testing the changes

Check List

…roject#4149) * Adds Repository Factory Provider Signed-off-by: Bandini Bhopi <[email protected]>

* enhance grouping for context menu options Signed-off-by: David Sinclair <[email protected]> * change log Signed-off-by: David Sinclair <[email protected]> * remove type export Signed-off-by: David Sinclair <[email protected]> * revert border and prevent destroy options Signed-off-by: David Sinclair <[email protected]> * update comments for building panels Signed-off-by: David Sinclair <[email protected]> * build panels tests and more comments Signed-off-by: David Sinclair <[email protected]> * add category option for context menus Signed-off-by: David Sinclair <[email protected]> * changelog Signed-off-by: David Sinclair <[email protected]> * add order to groups Signed-off-by: David Sinclair <[email protected]> * documentation, shorter copyrighty, minor cleanup Signed-off-by: David Sinclair <[email protected]> * changelog Signed-off-by: David Sinclair <[email protected]> --------- Signed-off-by: David Sinclair <[email protected]> Signed-off-by: David Sinclair <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> Co-authored-by: Ashish Agrawal <[email protected]>

…-project#4026) * Add bluebird replaces for src/plugins/saved_objects * Add changelog entry --------- Signed-off-by: Alexei Karikov <[email protected]>

…#4275) Signed-off-by: Su <[email protected]>

* links Signed-off-by: Aigerim Suleimenova <[email protected]> * new section for doveloper guide Signed-off-by: Aigerim Suleimenova <[email protected]> * updates Signed-off-by: Aigerim Suleimenova <[email protected]> * Update DEVELOPER_GUIDE.md Co-authored-by: Ashwin P Chandran <[email protected]> Signed-off-by: Aigerim Suleimenova <[email protected]> * Update DEVELOPER_GUIDE.md Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Aigerim Suleimenova <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Josh Romero <[email protected]>

) * Enable data client with sample data server side * Add dataSourceId into savedObject Signed-off-by: Kristen Tian <[email protected]> * Functional list, install uninstall Signed-off-by: Kristen Tian <[email protected]> * add change log Signed-off-by: Kristen Tian <[email protected]> * address comments Signed-off-by: Kristen Tian <[email protected]> * add ut Signed-off-by: Kristen Tian <[email protected]> --------- Signed-off-by: Kristen Tian <[email protected]>

* Copy over the labels from the original PR * Label the backport PR with `autocut` * Label a PR that fails to backport Signed-off-by: Miki <[email protected]>

…search-project#4237) Signed-off-by: Miki <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]>

…d()[0]` (opensearch-project#4363) Signed-off-by: Manasvini B Suryanarayana <[email protected]>

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

…ind()` (opensearch-project#4366) Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* [Lint] add custom stylelint rules and config Adding `@osd/stylelint-config` and `@osd/stylelint-plugin-stylelint` packages. These packages are utilized by OSD core and can be ran with the following: `yarn lint:style` Can be used to fix known non-compliant styling with the following: `yarn lint:style --fix` Can be used to audit untracked styling (based on defined rules) with the following: ``` export OUI_AUDIT_ENABLED=true yarn lint:style ``` --- `@osd/stylelint-config` Defines rules approved by UX and OSD core in JSON files and is added to OSD core. Within this commit is defined `colors.json` and `global_selectors.json`. `colors.json` defines a property that can be matched with a regex of a selector. If the selector is tracked it will have an `approved` value and a list of `rejected` values that UX knows if a value should be something. `global_selectors.json` defines a selector that if tracked, it will have an `approved` list of relative paths to files that can modify the global selector. --- `@osd/stylelint-plugin-stylelint` Creates the functionality that utilizes the JSON files within the `@osd/stylelint-config`. Within this commit is defined `no_custom_colors` and `no_modifying_global_selectors` rules. `no_custom_colors` checks if a property is a color property. It then utilizes a compliance engine helper to check the `colors.json` to see if the property being modified has a compliance rule available for the property for the specific selector and if it is not compliant. For example, if a selector matches `button` and we are trying to apply `background-color: red` to it. Stylelint will catch this and flag this as a known non-compliance issue since it knows that it should `$euiColorWarning`. If we pass `--fix` the property will be updated to be `$euiColorWarning`. If `OUI_AUDIT_ENABLED` is true it will catch all `background-color` being modified that is not being defined explicitly in `colors.json` `no_modifying_global_selectors` checks if a selector being modified is defined in `global_selectors.json` to see if a selector not defined in a specific list of approved files. For example, if a selector matches `#opensearch-dashboards-body` and it is being modified in `src/core/public/rendering/_base.scss`. Stylelint will catch this and flag this as a non-compliance issue. Since no other file should be modifying this selector. If we pass `--fix` the styling will be complete removed from the non-compliant file. --- Next steps: * Migrate these packages to OUI * Consider adding `yarn lint:style --fix` to the build release script here: https://github.com/opensearch-project/opensearch-build/blob/main/scripts/default/opensearch-dashboards/build.sh#L89 Issue: opensearch-project#4246 Signed-off-by: Kawika Avilla <[email protected]> * fix to use find Signed-off-by: Kawika Avilla <[email protected]> * Add regex matching and OUI modification lint Signed-off-by: Matt Provost <[email protected]> * add changelog Signed-off-by: Josh Romero <[email protected]> * address issues Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Matt Provost <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Matt Provost <[email protected]> Co-authored-by: Josh Romero <[email protected]>

Signed-off-by: Miki <[email protected]>

Also now: * `theme:darkMode` and `theme:version` can be configured via `defaults` * unauthenticated users are no longer forced to light mode Signed-off-by: Miki <[email protected]>

…ct#4294) * Refactor color to use OUI * Pull theme value from actual active theme * Update changelog --------- Signed-off-by: Matt Provost <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Josh Romero <[email protected]>

…t#4384) * Remove broken documentation link for Ruby API https://apidock.com/ruby/Time/to_i is currently down for maintenance But we don't need this link anyway, because it's talking about standard methods. And we plan to deprecate flot_charts altogether: opensearch-project#4267 Signed-off-by: Josh Romero <[email protected]> * remove leftover link brackets Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]>

* Fix relationships header overflow (opensearch-project#3967) Co-authored-by: Andrey Myssak <[email protected]> Signed-off-by: Sergey Myssak <[email protected]> * Replace relationships css file with oui classname (opensearch-project#3967) Co-authored-by: Andrey Myssak <[email protected]> Signed-off-by: Sergey Myssak <[email protected]> * Make title overflow wrap instead of truncation (opensearch-project#3967) Co-authored-by: Andrey Myssak <[email protected]> Signed-off-by: Sergey Myssak <[email protected]> * Remove icon from flyout header and wrap title Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Sergey Myssak <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> Co-authored-by: Josh Romero <[email protected]>

* Remove color_util Signed-off-by: Matt Provost <[email protected]> * Update changelog Signed-off-by: Matt Provost <[email protected]> * Revert "Remove color_util" This reverts commit 9ca9c56. Signed-off-by: Matt Provost <[email protected]> * Refactor color maps to use Oui color palettes Signed-off-by: Matt Provost <[email protected]> * Update changelog pt 2: electric boogaloo Signed-off-by: Matt Provost <[email protected]> * Make gradients look better Signed-off-by: Matt Provost <[email protected]> * Fix typescript ignore Signed-off-by: Matt Provost <[email protected]> * Fix tests Signed-off-by: Matt Provost <[email protected]> * Add todo followup Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]>

…#3964) * Remove unused tags in the navigation plugin (opensearch-project#3962) Signed-off-by: Andrey Myssak <[email protected]> * Update CHANGELOG.md (opensearch-project#3962) Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Signed-off-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]>

* Add invalid properties rule Signed-off-by: Matt Provost <[email protected]> * Update changelog Signed-off-by: Matt Provost <[email protected]> * Rename old variable Signed-off-by: Matt Provost <[email protected]> * Add types for configs Signed-off-by: Matt Provost <[email protected]> * Rename rule to no_restricted_properties Signed-off-by: Matt Provost <[email protected]> * Refactor duplicate functions into generic one Signed-off-by: Matt Provost <[email protected]> * Add type definitions Signed-off-by: Matt Provost <[email protected]> * Add some documentation about supported config types Signed-off-by: Matt Provost <[email protected]> * Update changelog Signed-off-by: Matt Provost <[email protected]> * Optchain instead of unwrapping source file Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]>

…osd-opensearch-archiver` package (opensearch-project#4142) Signed-off-by: Manasvini B Suryanarayana <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]>

…arch-project#4408) * Chore (deps): Bump OUI to 1.1.1 to add anomoly detection icon Signed-off-by: Josh Romero <[email protected]> * update changelog Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]>

…4415) * fix: Link checker exclude Signed-off-by: Ashwin P Chandran <[email protected]> * just ignore the broken URL for now Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]>

opensearch-project#4348) Signed-off-by: Manasvini B Suryanarayana <[email protected]>

…t#4427) * chore: Adds 1.3.11 release notes * chore: Adds 1.3.11 release notes updated --------- (cherry picked from commit 63908e8) Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…h-project#4430) * chore: Adds 1.3.11 release notes * chore: Adds 1.3.11 release notes updated * chore: Adds 1.3.11 release notes adds skipped changelog PR --------- (cherry picked from commit 7de483f) Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Add typing to Stylelint rules Signed-off-by: Matt Provost <[email protected]> * Extract get color property parent into function Signed-off-by: Matt Provost <[email protected]> * Optchain instead of unwrapping source file Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> Co-authored-by: Josh Romero <[email protected]>

…aletteColorBlind() (opensearch-project#4398) Signed-off-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]>

…pensearch-project#4411) In this PR, we resolve semver to 7.5.3 from 5.x, 6.x and 7.x. There are breaking changes in API in 7.5.3 compared to 5.x/6.x. However, these API changes do not impact any usages. Issue Resolve opensearch-project#4370 Signed-off-by: ananzh <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]>

…ect#4412) Signed-off-by: Kristen Tian <[email protected]>

opensearch-project#4658) * Fix (Legacy Maps): Add necessary specificity for dark mode style overrides - wrap override styles in visualization selector - remove temp SASS var - update attribution background to be opaque for consistency with other controls - add raster tile filter to map tiles in dark mode, since OpenSearch doesn't serve dark mode raster tilesets - Fix tooltip behavior so that tooltip only appears when there's content to render fixes opensearch-project/dashboards-maps#449, fixes opensearch-project/dashboards-maps#450 Signed-off-by: Josh Romero <[email protected]> * update changelog Signed-off-by: Josh Romero <[email protected]> * Fix spacing linter issues Signed-off-by: Josh Romero <[email protected]> * Update font-family overrides to use CSS var definitions Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]>

…-project#4651) Also: * bump `sass-loader` to a version that supports this `node-sass` Signed-off-by: Miki <[email protected]>

Also: * Bump browserslist * Widen browser support matrix * Update browser typescript target to ES2018 * Bump `autoprefixer` but remove its usage as it spams the logs about it being unnecessary Signed-off-by: Miki <[email protected]>

Signed-off-by: Miki <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>

…ensearch-project#4674) * Add missing quotes to --font-text CSS vars Signed-off-by: Josh Romero <[email protected]> * Fix usage of --font-text CSS var Remove quotes Add additional leaflet font family overrides Move legacy map custom button styles to separate file Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]>

codecov · 2023-08-07T20:58:23Z

Codecov Report

Merging #4691 (6bb07b9) into feature/data-explorer (521f306) will decrease coverage by 0.20%.
Report is 1 commits behind head on feature/data-explorer.
The diff coverage is 57.58%.

@@                    Coverage Diff                    @@
##           feature/data-explorer    #4691      +/-   ##
=========================================================
- Coverage                  66.50%   66.31%   -0.20%     
=========================================================
  Files                       3289     3378      +89     
  Lines                      62821    64637    +1816     
  Branches                    9788    10300     +512     
=========================================================
+ Hits                       41782    42865    +1083     
- Misses                     18658    19239     +581     
- Partials                    2381     2533     +152

Flag	Coverage Δ
Linux_1	`34.83% <8.96%> (?)`
Linux_2	`55.04% <84.33%> (?)`
Linux_3	`43.89% <43.13%> (?)`
Linux_4	`35.10% <14.56%> (?)`
Windows	`?`
Windows_1	`34.84% <8.96%> (?)`
Windows_2	`55.01% <84.33%> (?)`
Windows_3	`43.89% <43.13%> (?)`
Windows_4	`35.10% <14.56%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
packages/osd-babel-preset/node_preset.js	`100.00% <ø> (ø)`
...osd-opensearch-archiver/src/lib/docs/test_stubs.ts	`68.75% <ø> (ø)`
...ch-archiver/src/lib/indices/create_index_stream.ts	`69.76% <ø> (ø)`
...ch-archiver/src/lib/indices/delete_index_stream.ts	`50.00% <ø> (ø)`
...ver/src/lib/indices/opensearch_dashboards_index.ts	`0.00% <0.00%> (ø)`
packages/osd-ui-shared-deps/theme.ts	`41.66% <0.00%> (ø)`
src/core/server/legacy/legacy_service.ts	`75.38% <ø> (ø)`
src/core/server/plugins/plugin_context.ts	`45.45% <ø> (ø)`
src/core/server/rendering/views/template.tsx	`100.00% <ø> (ø)`
...server/saved_objects/saved_objects_service.mock.ts	`100.00% <ø> (ø)`
... and 70 more

... and 207 files with indirect coverage changes

ashwin-pc · 2023-08-08T00:46:05Z

CI Group 1 fails because of legacy discover style rules.

BSFishy · 2023-08-08T00:50:42Z

packages/osd-stylelint-config/config/global_selectors.json

+      "src/plugins/discover/public/application/components/sidebar/discover_sidebar.scss",
+      "src/plugins/discover/public/application/angular/doc_table/components/table_row/_open.scss"


Looks like these paths got renamed

BSFishy · 2023-08-08T00:51:13Z

packages/osd-stylelint-config/config/restricted_properties.json

+{
+  "font-family": {
+    "approved": [
+      "src/plugins/discover/public/application/_discover.scss",


Signed-off-by: Ashwin P Chandran <[email protected]>

bandinib-amzn and others added 30 commits June 5, 2023 15:39

[Saved Object Service] Adds Repository Factory Provider (opensearch-p…

5c5de03

…roject#4149) * Adds Repository Factory Provider Signed-off-by: Bandini Bhopi <[email protected]>

[CCI] Add bluebird replaces for src/plugins/saved_objects (opensearch…

55b293a

…-project#4026) * Add bluebird replaces for src/plugins/saved_objects * Add changelog entry --------- Signed-off-by: Alexei Karikov <[email protected]>

Validate and correct change log after 2.8 release (opensearch-project…

2322c53

…#4275) Signed-off-by: Su <[email protected]>

Upgrade the backport workflow (opensearch-project#4343)

84ec854

* Copy over the labels from the original PR * Label the backport PR with `autocut` * Label a PR that fails to backport Signed-off-by: Miki <[email protected]>

Hide any output from use_node checking for Node compatibility (open…

f298e7e

…search-project#4237) Signed-off-by: Miki <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]>

[Vis Colors] Update default color in TSVB to use `ouiPaletteColorBlin…

333e2b3

…d()[0]` (opensearch-project#4363) Signed-off-by: Manasvini B Suryanarayana <[email protected]>

Add BWC tests for 2.7 and 2.8 (opensearch-project#4023)

93d543e

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

[Vis colors] Replace vis_type_timeline colors with `ouiPaletteColorBl…

d95504c

…ind()` (opensearch-project#4366) Signed-off-by: Manasvini B Suryanarayana <[email protected]>

Fix linked deps resolution (opensearch-project#4342)

931b915

Signed-off-by: Miki <[email protected]>

Add configurable defaults to uiSettings (opensearch-project#4344)

fe1f1d1

Also now: * `theme:darkMode` and `theme:version` can be configured via `defaults` * unauthenticated users are no longer forced to light mode Signed-off-by: Miki <[email protected]>

[Vis Colors] Update legacy seed colors to use ouiPaletteColorBlind() (

88e2b2d

opensearch-project#4348) Signed-off-by: Manasvini B Suryanarayana <[email protected]>

[Vis colors] Update legacy mapped colors in charts plugin to use ouiP…

5e8a4fd

…aletteColorBlind() (opensearch-project#4398) Signed-off-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]>

Enable sample data with Multiple datasource frontend (opensearch-proj…

7c8aa4a

…ect#4412) Signed-off-by: Kristen Tian <[email protected]>

joshuarrrr and others added 7 commits August 3, 2023 10:42

Bump node-sass to a version that uses a newer libsass (opensearch…

bf6e887

…-project#4651) Also: * bump `sass-loader` to a version that supports this `node-sass` Signed-off-by: Miki <[email protected]>

Reduce the amount of comments in compiled CSS (opensearch-project#4648)

4bc1f55

Signed-off-by: Miki <[email protected]>

units test for utils folder (opensearch-project#4641)

324919d

Signed-off-by: abbyhu2000 <[email protected]>

Merge branch 'main' into merge-main

81f25e0

ashwin-pc requested review from ananzh, kavilla, seanneumann, AMoo-Miki, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu, manasvinibs, ZilongX and Flyingliuhub as code owners August 7, 2023 20:35

github-actions bot added the distinguished-contributor label Aug 7, 2023

ashwin-pc added discover for discover reinvent de-angular de-angularize work data explorer Issues related to the Data Explorer project labels Aug 7, 2023

BSFishy reviewed Aug 8, 2023

View reviewed changes

fixes incorrect path for css ignore

6bb07b9

Signed-off-by: Ashwin P Chandran <[email protected]>

ananzh approved these changes Aug 8, 2023

View reviewed changes

abbyhu2000 approved these changes Aug 8, 2023

View reviewed changes

ashwin-pc merged commit 838745f into opensearch-project:feature/data-explorer Aug 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Data Explorer] Merging main to feature branch #4691

[Data Explorer] Merging main to feature branch #4691

ashwin-pc commented Aug 7, 2023

codecov bot commented Aug 7, 2023 •

edited

Loading

ashwin-pc commented Aug 8, 2023

BSFishy Aug 8, 2023

BSFishy Aug 8, 2023

		"src/plugins/discover/public/application/components/sidebar/discover_sidebar.scss",
		"src/plugins/discover/public/application/angular/doc_table/components/table_row/_open.scss"

[Data Explorer] Merging main to feature branch #4691

[Data Explorer] Merging main to feature branch #4691

Conversation

ashwin-pc commented Aug 7, 2023

Description

Issues Resolved

Screenshot

Testing the changes

Check List

codecov bot commented Aug 7, 2023 • edited Loading

Codecov Report

ashwin-pc commented Aug 8, 2023

BSFishy Aug 8, 2023

Choose a reason for hiding this comment

BSFishy Aug 8, 2023

Choose a reason for hiding this comment

codecov bot commented Aug 7, 2023 •

edited

Loading