Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x] Refactor logo usage (#4702) #4796

Merged

Conversation

AMoo-Miki
Copy link
Collaborator

cherry picked d7c5577 from #4702

Also:
* Move logos to a central location
* Make the loading spinner color-scheme-aware
* Recreate `OverviewPageHeader`, `HomeIcon`, `HeaderLogo`, `SolutionTitle`, `Welcome`, `Overview` tests
* Enhance `ExitFullScreenButton`, `Header` tests
* Tinified favicon assets

Signed-off-by: Miki <[email protected]>

(cherry picked from commit d7c5577)
Signed-off-by: Miki <[email protected]>
@AMoo-Miki AMoo-Miki changed the title [Manual Backport] Refactor logo usage (#4702) [Manual Backport 2.x] Refactor logo usage (#4702) Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #4796 (987ba00) into 2.x (d8f156f) will increase coverage by 0.02%.
The diff coverage is 96.20%.

@@            Coverage Diff             @@
##              2.x    #4796      +/-   ##
==========================================
+ Coverage   66.10%   66.12%   +0.02%     
==========================================
  Files        3315     3317       +2     
  Lines       63909    63869      -40     
  Branches    10126    10105      -21     
==========================================
- Hits        42248    42236      -12     
+ Misses      19180    19150      -30     
- Partials     2481     2483       +2     
Flag Coverage Δ
Linux_1 34.86% <57.35%> (+0.08%) ⬆️
Linux_2 55.13% <95.52%> (+0.03%) ⬆️
Linux_3 43.15% <56.33%> (+0.12%) ⬆️
Linux_4 35.14% <63.29%> (+0.05%) ⬆️
Windows_1 34.87% <57.35%> (?)
Windows_2 55.10% <95.52%> (+0.03%) ⬆️
Windows_3 43.16% <56.33%> (+0.12%) ⬆️
Windows_4 35.14% <63.29%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/public/chrome/chrome_service.mock.ts 100.00% <ø> (ø)
src/core/public/chrome/ui/header/home_loader.tsx 17.14% <ø> (ø)
src/core/server/rendering/rendering_service.tsx 66.66% <ø> (ø)
src/core/server/rendering/views/styles.tsx 100.00% <ø> (ø)
...ication/embeddable/dashboard_container_factory.tsx 0.00% <ø> (ø)
...ication/embeddable/viewport/dashboard_viewport.tsx 85.18% <ø> (ø)
src/plugins/dashboard/public/plugin.tsx 0.00% <ø> (ø)
...plugins/home/public/application/components/home.js 91.48% <ø> (ø)
src/core/common/logos/get_logos.ts 93.02% <93.02%> (ø)
src/core/common/logos/get_logos.mock.ts 100.00% <100.00%> (ø)
... and 14 more

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants