-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manual Backport 2.x] Refactor logo usage (#4702) #4796
Merged
joshuarrrr
merged 2 commits into
opensearch-project:2.x
from
AMoo-Miki:backport/backport-4702-to-2.x
Aug 29, 2023
Merged
[Manual Backport 2.x] Refactor logo usage (#4702) #4796
joshuarrrr
merged 2 commits into
opensearch-project:2.x
from
AMoo-Miki:backport/backport-4702-to-2.x
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Move logos to a central location * Make the loading spinner color-scheme-aware * Recreate `OverviewPageHeader`, `HomeIcon`, `HeaderLogo`, `SolutionTitle`, `Welcome`, `Overview` tests * Enhance `ExitFullScreenButton`, `Header` tests * Tinified favicon assets Signed-off-by: Miki <[email protected]> (cherry picked from commit d7c5577) Signed-off-by: Miki <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #4796 +/- ##
==========================================
+ Coverage 66.10% 66.12% +0.02%
==========================================
Files 3315 3317 +2
Lines 63909 63869 -40
Branches 10126 10105 -21
==========================================
- Hits 42248 42236 -12
+ Misses 19180 19150 -30
- Partials 2481 2483 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stephen-crawford
approved these changes
Aug 24, 2023
9 tasks
joshuarrrr
approved these changes
Aug 29, 2023
manasvinibs
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry picked d7c5577 from #4702