[Test] Enable schema_error.test.ts #488

ananzh · 2021-06-17T16:05:55Z

Signed-off-by: Anan Zhuang [email protected]

Description

This is skipped because in 2017 there is no decision around error handling in the new platform. We can enable the unit test for error handling.

The error message is:

    { Error: test
        at Object.<anonymous>.it (/home/anan/work/OpenSearch-Dashboards/packages/osd-config-schema/src/errors/schema_error.test.ts:61:11)
        at Object.asyncJestTest (/home/anan/work/OpenSearch-Dashboards/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
        at resolve (/home/anan/work/OpenSearch-Dashboards/node_modules/jest-jasmine2/build/queueRunner.js:45:12)
        at new Promise (<anonymous>)
        at mapper (/home/anan/work/OpenSearch-Dashboards/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
        at promise.then (/home/anan/work/OpenSearch-Dashboards/node_modules/jest-jasmine2/build/queueRunner.js:75:41)
        at process._tickCallback (internal/process/next_tick.js:68:7) cause: undefined }

      at Object.<anonymous>.it (packages/osd-config-schema/src/errors/schema_error.test.ts:63:13)

After clean and select, following message will be compare to snapshot

    Error: test
        at Object.<anonymous>.it (packages/osd-config-schema/src/errors/schema_error.test.ts:61:11)
        at new Promise (<anonymous>)

Issues Resolved

#486

Test results

unit test for schema_error.test.ts

$ node scripts/jest /packages/osd-config-schema/src/errors/schema_error.test.ts
 PASS  packages/osd-config-schema/src/errors/schema_error.test.ts
  ✓ includes stack (5 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   1 passed, 1 total
Time:        1.659 s

overall unit test:

Test Suites: 22 skipped, 1412 passed, 1412 of 1434 total
Tests:       257 skipped, 9 todo, 10358 passed, 10624 total
Snapshots:   2364 passed, 2364 total
Time:        44.997 s

integration test:

Test Suites: 50 passed, 50 total
Tests:       3 skipped, 434 passed, 437 total
Snapshots:   73 passed, 73 total
Time:        314.149 s

functional test: see below image

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

opensearch-ci-bot · 2021-06-17T16:08:27Z

✅ DCO Check Passed 44a11a6

ananzh · 2021-06-17T16:24:03Z

kavilla · 2021-06-17T19:17:36Z

Should be able to run the full pipeline, no cherry picking as long as you rebased main. Can we actually run this fully on the CI pipeline as well. Some tests like to work locally but fail on the CI.

kavilla · 2021-06-17T19:20:04Z

From reading the comment it seems like related to unknown aspects about node versions and if the test fails on different node versions. Could I get some clarity on that?

kavilla · 2021-06-17T19:41:24Z

Could the commit description have some details about why we are able to re-enable it.

ananzh · 2021-06-17T23:10:31Z

Should be able to run the full pipeline, no cherry picking as long as you rebased main. Can we actually run this fully on the CI pipeline as well. Some tests like to work locally but fail on the CI.

will do, here is the jenkins test (unit+integration+fun):

tmarkley · 2021-06-18T04:02:35Z

Could the commit description have some details about why we are able to re-enable it.

Agreed, let's make sure we're adding helpful details to the commit messages.

ananzh · 2021-06-18T06:10:13Z

From reading the comment it seems like related to unknown aspects about node versions and if the test fails on different node versions. Could I get some clarity on that?

Yes. As mentioned in issue here, there is a discussion about error handling in 'new platform'. I am not sure the exact reason this test is skipped initially but I think two reasons are related: 1) I see there is a bump from nodejs6 to nodejs 8 in March,2018. As mentioned in this article here , there are changes in nodejs error handling. 2) Another error handling mentioned in the above issue is to use boom to handle HTTP errors. boom provides a set of error response object for returning HTTP errors. boom also depends on nodejs.

opensearch-ci-bot · 2021-06-18T06:26:09Z

❌ DCO Check Failed 349eadf
Run ./dev-tools/signoff-check.sh remotes/origin/main 349eadffb0bcb8e534e97a192a6290b3d48435be to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

ananzh · 2021-06-18T06:26:29Z

From reading the comment it seems like related to unknown aspects about node versions and if the test fails on different node versions. Could I get some clarity on that?

will amend the commit msg for this PR. thanks for the comment

opensearch-ci-bot · 2021-06-18T06:28:15Z

✅ DCO Check Passed 5cc37bd

ananzh · 2021-06-18T06:31:18Z

Could the commit description have some details about why we are able to re-enable it.

Agreed, let's make sure we're adding helpful details to the commit messages.

Will amend the commit message. Thanks for the comment.

opensearch-ci-bot · 2021-06-18T06:35:57Z

✅ DCO Check Passed 3d65188

…ct#486) Schema_error.test.ts is skipped due to no decision around error handling and it fails depending on Node version in 2017. There are some possible reasons: 1) nodejs is bumps to 8 in 2018 which affected error handling 2) boom is used to handle http errors which is also dependent on nodejs version. Since we forked from v7.10.2 which has a stable nodejs v10.23.1, we will enable this unit test. Signed-off-by: Anan Zhuang <[email protected]>

opensearch-ci-bot · 2021-06-18T20:46:21Z

✅ DCO Check Passed c503b6e

Schema_error.test.ts is skipped due to no decision around error handling and it fails depending on Node version in 2017. There are some possible reasons: 1) nodejs is bumps to 8 in 2018 which affected error handling 2) boom is used to handle http errors which is also dependent on nodejs version. Since we forked from v7.10.2 which has a stable nodejs v10.23.1, we will enable this unit test. Signed-off-by: Anan Zhuang <[email protected]>

ananzh added bug Something isn't working test:unit v1.0.0 labels Jun 17, 2021

ananzh requested review from tmarkley, kavilla and boktorbb June 17, 2021 16:05

ananzh self-assigned this Jun 17, 2021

ananzh mentioned this pull request Jun 17, 2021

[Test] Check skipped unit tests #483

Closed

26 tasks

ananzh force-pushed the i-486 branch 2 times, most recently from 349eadf to 5cc37bd Compare June 18, 2021 06:25

ananzh force-pushed the i-486 branch from 5cc37bd to 3d65188 Compare June 18, 2021 06:34

ananzh changed the title ~~Enable schema_error.test.ts~~ [Test] Enable schema_error.test.ts Jun 18, 2021

ananzh removed the bug Something isn't working label Jun 18, 2021

ananzh force-pushed the i-486 branch from 3d65188 to c503b6e Compare June 18, 2021 20:44

kavilla approved these changes Jun 21, 2021

View reviewed changes

tmarkley approved these changes Jun 21, 2021

View reviewed changes

ananzh merged commit 1cf9a7a into opensearch-project:main Jun 22, 2021

ananzh deleted the i-486 branch September 14, 2021 17:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Test] Enable schema_error.test.ts #488

[Test] Enable schema_error.test.ts #488

ananzh commented Jun 17, 2021 •

edited

Loading

opensearch-ci-bot commented Jun 17, 2021

ananzh commented Jun 17, 2021

kavilla commented Jun 17, 2021 •

edited by ananzh

Loading

kavilla commented Jun 17, 2021

kavilla commented Jun 17, 2021

ananzh commented Jun 17, 2021 •

edited

Loading

tmarkley commented Jun 18, 2021

ananzh commented Jun 18, 2021

opensearch-ci-bot commented Jun 18, 2021

ananzh commented Jun 18, 2021

opensearch-ci-bot commented Jun 18, 2021

ananzh commented Jun 18, 2021

opensearch-ci-bot commented Jun 18, 2021

opensearch-ci-bot commented Jun 18, 2021

[Test] Enable schema_error.test.ts #488

[Test] Enable schema_error.test.ts #488

Conversation

ananzh commented Jun 17, 2021 • edited Loading

Description

Issues Resolved

Test results

Check List

opensearch-ci-bot commented Jun 17, 2021

ananzh commented Jun 17, 2021

kavilla commented Jun 17, 2021 • edited by ananzh Loading

kavilla commented Jun 17, 2021

kavilla commented Jun 17, 2021

ananzh commented Jun 17, 2021 • edited Loading

tmarkley commented Jun 18, 2021

ananzh commented Jun 18, 2021

opensearch-ci-bot commented Jun 18, 2021

ananzh commented Jun 18, 2021

opensearch-ci-bot commented Jun 18, 2021

ananzh commented Jun 18, 2021

opensearch-ci-bot commented Jun 18, 2021

opensearch-ci-bot commented Jun 18, 2021

ananzh commented Jun 17, 2021 •

edited

Loading

kavilla commented Jun 17, 2021 •

edited by ananzh

Loading

ananzh commented Jun 17, 2021 •

edited

Loading