[Build] build:types and uiFramework run successfully #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing for the following builds to complete successfully: * `yarn build:types` * `yarn uiFramework:build` * `yarn uiFramework:start` Not positive about the expected results when running uiFramework:start but it seems to be on par with the legacy 7.10.2 version. Issue resolved: opensearch-project#680 Signed-off-by: Kawika Avilla <[email protected]>
|
✅ DCO Check Passed f906f18 |
|
|
boktorbb
approved these changes
Aug 25, 2021
|
Hey Rocky, why you mentioned here |
ananzh
approved these changes
Aug 30, 2021
So when I run the command I get nothing but a white screen, but I checked out the legacy application and did the same and I get the same behavior. From my understanding uiFramework is for pre-EUI, so it just hosts components and not to so much. But I could be incorrect since I am not able to find much information about it. |
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Aug 31, 2021
Allowing for the following builds to complete successfully: * `yarn build:types` * `yarn uiFramework:build` * `yarn uiFramework:start` Not positive about the expected results when running uiFramework:start but it seems to be on par with the legacy 7.10.2 version. Issue resolved: opensearch-project#680 Backport PR: opensearch-project#734 Signed-off-by: Kawika Avilla <[email protected]>
kavilla
added a commit
that referenced
this pull request
Aug 31, 2021
Allowing for the following builds to complete successfully: * `yarn build:types` * `yarn uiFramework:build` * `yarn uiFramework:start` Not positive about the expected results when running uiFramework:start but it seems to be on par with the legacy 7.10.2 version. Issue resolved: #680 Backport PR: #734 Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allowing for the following builds to complete successfully:
yarn build:typesyarn uiFramework:buildyarn uiFramework:startNot positive about the expected results when running uiFramework:start
but it seems to be on par with the legacy 7.10.2 version.
Issues Resolved
#680
Check List