-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] fail silently on register git hook failure #852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the Node CI is failing. Not sure if it’s intended because of the change or not
✅ DCO Check Passed b943712 |
Yeah looking into it's saying typescript version error which is strange. |
b943712
to
41ac938
Compare
✅ DCO Check Passed 41ac938 |
✅ DCO Check Passed a34db37 |
`node scripts/register_git_hook` fails depending on the installed git version because it ends up calling `git rev-parse --git-common-dir`. Depending on the git version, `--git-common-dir` returns the literal string `--git-common-dir` when it is suppose to return $GIT_COMMON_DIR if set and $GIT_DIR if the previous is not set. Then it proceeds to try to install from a path that doesn't exist because it will use `--git-common-dir` in the path. The goal for this fix is to bypass hard failures in 1.x since I do not believe it is appropriate to fail building something due to git. But I do not want to just remove adding the pre-commit git hook if people are already used to it being installed while bootstrapping. Here, I propose the removal of git hooks on bootstrap in a 2+ version of Dashboards: opensearch-project#851 Issue resolved: opensearch-project#850 Signed-off-by: Kawika Avilla <[email protected]>
a34db37
to
42211dd
Compare
✅ DCO Check Passed 42211dd |
Hacky but works. |
`node scripts/register_git_hook` fails depending on the installed git version because it ends up calling `git rev-parse --git-common-dir`. Depending on the git version, `--git-common-dir` returns the literal string `--git-common-dir` when it is suppose to return $GIT_COMMON_DIR if set and $GIT_DIR if the previous is not set. Then it proceeds to try to install from a path that doesn't exist because it will use `--git-common-dir` in the path. The goal for this fix is to bypass hard failures in 1.x since I do not believe it is appropriate to fail building something due to git. But I do not want to just remove adding the pre-commit git hook if people are already used to it being installed while bootstrapping. Here, I propose the removal of git hooks on bootstrap in a 2+ version of Dashboards: opensearch-project#851 Issue resolved: opensearch-project#850 Backport PR: opensearch-project#852 Signed-off-by: Kawika Avilla <[email protected]>
`node scripts/register_git_hook` fails depending on the installed git version because it ends up calling `git rev-parse --git-common-dir`. Depending on the git version, `--git-common-dir` returns the literal string `--git-common-dir` when it is suppose to return $GIT_COMMON_DIR if set and $GIT_DIR if the previous is not set. Then it proceeds to try to install from a path that doesn't exist because it will use `--git-common-dir` in the path. The goal for this fix is to bypass hard failures in 1.x since I do not believe it is appropriate to fail building something due to git. But I do not want to just remove adding the pre-commit git hook if people are already used to it being installed while bootstrapping. Here, I propose the removal of git hooks on bootstrap in a 2+ version of Dashboards: opensearch-project#851 Issue resolved: opensearch-project#850 Backport PR: opensearch-project#852 Signed-off-by: Kawika Avilla <[email protected]>
`node scripts/register_git_hook` fails depending on the installed git version because it ends up calling `git rev-parse --git-common-dir`. Depending on the git version, `--git-common-dir` returns the literal string `--git-common-dir` when it is suppose to return $GIT_COMMON_DIR if set and $GIT_DIR if the previous is not set. Then it proceeds to try to install from a path that doesn't exist because it will use `--git-common-dir` in the path. The goal for this fix is to bypass hard failures in 1.x since I do not believe it is appropriate to fail building something due to git. But I do not want to just remove adding the pre-commit git hook if people are already used to it being installed while bootstrapping. Here, I propose the removal of git hooks on bootstrap in a 2+ version of Dashboards: #851 Issue resolved: #850 Backport PR: #852 Signed-off-by: Kawika Avilla <[email protected]>
`node scripts/register_git_hook` fails depending on the installed git version because it ends up calling `git rev-parse --git-common-dir`. Depending on the git version, `--git-common-dir` returns the literal string `--git-common-dir` when it is suppose to return $GIT_COMMON_DIR if set and $GIT_DIR if the previous is not set. Then it proceeds to try to install from a path that doesn't exist because it will use `--git-common-dir` in the path. The goal for this fix is to bypass hard failures in 1.x since I do not believe it is appropriate to fail building something due to git. But I do not want to just remove adding the pre-commit git hook if people are already used to it being installed while bootstrapping. Here, I propose the removal of git hooks on bootstrap in a 2+ version of Dashboards: #851 Issue resolved: #850 Backport PR: #852 Signed-off-by: Kawika Avilla <[email protected]>
Description
node scripts/register_git_hook
fails depending on the installedgit version because it ends up calling
git rev-parse --git-common-dir
.Depending on the git version,
--git-common-dir
returns the literalstring
--git-common-dir
when it is suppose to return $GIT_COMMON_DIRif set and, if not, $GIT_DIR. Then it proceeds to try to install from a
path that doesn't exist because it will use
--git-common-dir
in thepath.
The goal for this fix is to bypass hard failures in 1.x since I do
not believe it is appropriate to fail building something due to git.
But I do not want to just remove adding the pre-commit git hook
if people are already used to it being installed while bootstrapping.
Here, I propose the removal of git hooks on bootstrap in a 2+ version
of Dashboards:
#851
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
#850
Check List