Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Encode searchId as it tends to be decoded after adds into url… #8549

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhyuanqi
Copy link
Collaborator

@zhyuanqi zhyuanqi commented Oct 10, 2024

Description

This reverts commit 9eae148. (#8530)
We revert this change as do not need it any more. It was for fixing the searchID as it would be decoded during generating URL. As we decide to switch searchID to UUID. We do not need this change any more.

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

1 similar comment
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.93%. Comparing base (2ffb11f) to head (8a64611).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8549      +/-   ##
==========================================
- Coverage   60.93%   60.93%   -0.01%     
==========================================
  Files        3771     3771              
  Lines       89545    89544       -1     
  Branches    14017    14016       -1     
==========================================
- Hits        54566    54565       -1     
  Misses      31569    31569              
  Partials     3410     3410              
Flag Coverage Δ
Linux_1 29.00% <ø> (-0.01%) ⬇️
Linux_2 56.27% <ø> (ø)
Linux_3 37.75% <ø> (+<0.01%) ⬆️
Linux_4 29.92% <ø> (ø)
Windows_1 29.02% <ø> (-0.01%) ⬇️
Windows_2 56.23% <ø> (ø)
Windows_3 37.75% <ø> (+<0.01%) ⬆️
Windows_4 29.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant