[TESTID-125,126,127,128,129] Saved Query Test Scope #9229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
… old ui and new ui commands Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
…queries Signed-off-by: Argus Li <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9229 +/- ##
=======================================
Coverage 61.68% 61.68%
=======================================
Files 3816 3816
Lines 91693 91693
Branches 14516 14516
=======================================
+ Hits 56557 56559 +2
+ Misses 31510 31509 -1
+ Partials 3626 3625 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
angle943
suggested changes
Jan 21, 2025
...search_dashboards/opensearch_dashboards/apps/query_enhancements/saved_queries_flyout.spec.js
Outdated
Show resolved
Hide resolved
...search_dashboards/opensearch_dashboards/apps/query_enhancements/saved_queries_flyout.spec.js
Outdated
Show resolved
Hide resolved
...earch_dashboards/opensearch_dashboards/apps/query_enhancements/saved_queries_popover.spec.js
Outdated
Show resolved
Hide resolved
...earch_dashboards/opensearch_dashboards/apps/query_enhancements/saved_queries_popover.spec.js
Outdated
Show resolved
Hide resolved
...earch_dashboards/opensearch_dashboards/apps/query_enhancements/saved_queries_popover.spec.js
Outdated
Show resolved
Hide resolved
...search_dashboards/opensearch_dashboards/apps/query_enhancements/saved_queries_flyout.spec.js
Outdated
Show resolved
Hide resolved
...search_dashboards/opensearch_dashboards/apps/query_enhancements/saved_queries_flyout.spec.js
Outdated
Show resolved
Hide resolved
ananzh
changed the title
|
@ArgusLi I think we could always assume that |
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Argus Li <[email protected]>
angle943
approved these changes
Jan 22, 2025
Signed-off-by: Argus Li <[email protected]>
angle943
reviewed
Jan 24, 2025
| SAVE_AS_NEW_QUERY_SUFFIX, | ||
| validateSaveAsNewQueryMatchingNameHasError, | ||
| } from '../../../../../utils/apps/query_enhancements/saved_queries'; | ||
|
|
There was a problem hiding this comment.
can we rename this file to saved_queries.spec.js
Signed-off-by: Argus Li <[email protected]>
…queries Signed-off-by: Argus Li <[email protected]>
angle943
reviewed
Jan 24, 2025
|
|
||
| // This spec assumes data.savedQueriesNewUI.enabled is true. | ||
| export const runSavedQueriesFlyoutUITests = () => { | ||
| describe('saved queries flyout UI', () => { |
Signed-off-by: Argus Li <[email protected]>
ananzh
previously approved these changes
Jan 24, 2025
LDrago27
added
backport 2.x
discover_2.0-test
Signed-off-by: Argus Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Cypress test suite for Saved Queries Test Scope in the Discover page.
Issues Resolved
Closes #8975, #8977, #8978, #8979, #8980.
Screenshot
saved-queries-1.mp4
saved-queries-2.mp4
saved-queries-3.mp4
Testing the changes
With OSD running, run
yarn run cypress open. In E2E specs, you will see 2 new test specssaved_queries.spec.jsandsaved_queries_old_ui.spec.js. Runsaved_queries.spec.jsifdata.savedQueriesNewUI.enabled: truein the OSD config, else runsaved_queries_old_ui.spec.js.Changelog