-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cypress data to have random id, missing value fields and unique field #9321
Conversation
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9321 +/- ##
=======================================
Coverage 61.70% 61.71%
=======================================
Files 3816 3816
Lines 91829 91829
Branches 14543 14543
=======================================
+ Hits 56666 56668 +2
+ Misses 31507 31506 -1
+ Partials 3656 3655 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…e field * Random id generation in TestDataGenerator * Add a unique field to test modifyColumnsOnSwitch * Update mapping and include a never present field to test hide missing values Signed-off-by: Anan <[email protected]>
e3d20a6
to
9de6f9e
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-9321-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 13408e1d47d9decd9c85f30db4169d3c0b1db1a2
# Push it to GitHub
git push --set-upstream origin backport/backport-9321-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
Description
There is an advanced settings for discover called
modifyColumnsOnSwitch
. By default (turn on), this settings will remove columns that are not available in the new index pattern when switch. Therefore we need a different field for time_1 data and time_2 data.There is another feature called
hide missing values
in discover. An example to verify this featurethen create an index pattern
a*
. For field_always_missing field, it only has a mapping but no value. When hide missing values in discover is on, you won't see this field in the side panel in discover. When hide missing values is off this field should show in side panel. So we need to update the script to include such field but don't need to create values for them.Issues Resolved
NA
Screenshot
NA
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration