fix: flaky test ClusterMetadataManifestTests

We're comparing for unequal manifests but randomBoolean() has a high probability of getting clashed because of a small search-space, making test flaky. Let's limit randomization here. Signed-off-by: Rohit Ashiwal <[email protected]>
opensearch-project · Sep 4, 2023 · 7cd5355 · 7cd5355
1 parent d375e4c
commit 7cd5355
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/server/src/test/java/org/opensearch/gateway/remote/ClusterMetadataManifestTests.java b/server/src/test/java/org/opensearch/gateway/remote/ClusterMetadataManifestTests.java
@@ -90,7 +90,7 @@ public void testClusterMetadataManifestSerializationEqualsHashCode() {
                         builder.nodeId(randomAlphaOfLength(10));
                         break;
                     case 6:
-                        builder.committed(randomBoolean());
+                        builder.committed(!manifest.isCommitted());
                         break;
                     case 7:
                         builder.indices(randomUploadedIndexMetadataList());