Changing unit tests for targetservice class.

Signed-off-by: Rishikesh1159 <[email protected]>
opensearch-project · Jun 16, 2022 · efb1f8f · efb1f8f
1 parent 7cdd4fa
commit efb1f8f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java b/server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java
@@ -125,13 +125,7 @@ public void onReplicationDone(SegmentReplicationState state) {
                     // if we received a checkpoint during the copy event that is ahead of this
                     // try and process it.
                     if (getLatestReceivedCheckpoint(indexShard.shardId()).isAheadOf(indexShard.getLatestReplicationCheckpoint())) {
-                        threadPool.generic()
-                            .execute(
-                                () -> onNewCheckpoint(
-                                    getLatestReceivedCheckpoint(indexShard.shardId()),
-                                    indexShard
-                                )
-                            );
+                        onNewCheckpoint(getLatestReceivedCheckpoint(indexShard.shardId()), indexShard);
                     }
                 }
 

diff --git a/...rc/test/java/org/opensearch/indices/replication/SegmentReplicationTargetServiceTests.java b/...rc/test/java/org/opensearch/indices/replication/SegmentReplicationTargetServiceTests.java
@@ -188,13 +188,14 @@ public void testReplicationOnDone() throws IOException {
         );
         spy.onNewCheckpoint(newCheckpoint, spyShard);
         spy.onNewCheckpoint(newCheckpoint2, spyShard);
+        verify(spy, times(1)).onNewCheckpoint(eq(newCheckpoint2), any());
         ArgumentCaptor<SegmentReplicationTargetService.SegmentReplicationListener> captor = ArgumentCaptor.forClass(
             SegmentReplicationTargetService.SegmentReplicationListener.class
         );
-        verify(spy, times(1)).startReplication(any(), any(), captor.capture());
+        verify(spy, times(1)).startReplication(eq(newCheckpoint), any(), captor.capture());
         SegmentReplicationTargetService.SegmentReplicationListener listener = captor.getValue();
         listener.onDone(new SegmentReplicationState());
-        verify(spy, times(1)).startReplication(any(), any(), any());
+        verify(spy, times(2)).onNewCheckpoint(eq(newCheckpoint2), any());
         closeShard(indexShard, false);
 
     }