Removing idex sort fiild from testUpdateSnapshotStatus #10080
Conversation
gashutos
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
peternied,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis,
sachinpkale,
sohami and
msfroh
as code owners
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 5fdd418 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
| @@ -387,7 +387,7 @@ public void testUpdateSnapshotStatus() throws Exception { | |||
| Settings.Builder settings = Settings.builder() | |||
| .put(IndexMetadata.INDEX_NUMBER_OF_SHARDS_SETTING.getKey(), between(5, 10)) | |||
| .put(IndexMetadata.INDEX_NUMBER_OF_REPLICAS_SETTING.getKey(), 1) | |||
| .putList("index.sort.field", "sortfield") | |||
| //.putList("index.sort.field", "sortfield") /* disabling as of now as it breaks non production scenario */ | |||
There was a problem hiding this comment.
@gashutos just trying to understand if we are phasing out a valid scenario:
- assume the index is created in 1.3 with index sort
- the snapshot of this index is taken
- the snapshot is restored in 2.11
That should work, right? Or the test does something different? If we comment out index.sort.field, the original flow that triggers the issue won't be exercised, right?
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10080 +/- ##
============================================
- Coverage 71.03% 71.03% -0.01%
- Complexity 58071 58090 +19
============================================
Files 4824 4825 +1
Lines 273918 273976 +58
Branches 39918 39922 +4
============================================
+ Hits 194591 194622 +31
- Misses 63017 63036 +19
- Partials 16310 16318 +8
|
Gradle Check (Jenkins) Run Completed with:
|
This addition is breaking in 2.x
#10075.
The reason is, index is getting created in mixed cluster on newer versions, and shards are routed back to old versions, and then from old version it is trying to restore snapshot to newer version.
Our fix introduced here #10045 wont work in this case as Index version is already newer version, this wont be the scenario in real world. So removing as of now to unblock critical upgrade fix.
Between this line was added in PR #10045 only