Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Add log for failover time #10952

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

Poojita-Raj
Copy link
Contributor

@Poojita-Raj Poojita-Raj commented Oct 26, 2023

Description

Adds a log for duration of failover time that will help in debugging issues.

Related Issues

Resolves #10951

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Poojita-Raj Poojita-Raj self-assigned this Oct 26, 2023
@github-actions github-actions bot added bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep labels Oct 26, 2023
@Poojita-Raj Poojita-Raj removed bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep labels Oct 26, 2023
@github-actions github-actions bot added bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep labels Oct 26, 2023
@Poojita-Raj Poojita-Raj added the backport 2.x Backport to 2.x branch label Oct 26, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Compatibility status:

Checks if related components are compatible with change c3733d4

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

Signed-off-by: Poojita Raj <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Rishikesh1159
Copy link
Member

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/29105/

* **CommitID:** [c3733d4](https://github.com/opensearch-project/OpenSearch/commit/c3733d470c11f384db3951355d8cbbde3aadbe04)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

#10154
#9332

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #10952 (c3733d4) into main (5ae9333) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main   #10952      +/-   ##
============================================
- Coverage     71.28%   71.27%   -0.01%     
- Complexity    58721    58765      +44     
============================================
  Files          4872     4872              
  Lines        276701   276707       +6     
  Branches      40222    40222              
============================================
- Hits         197248   197229      -19     
- Misses        62954    63001      +47     
+ Partials      16499    16477      -22     
Files Coverage Δ
...in/java/org/opensearch/index/shard/IndexShard.java 70.31% <100.00%> (+0.34%) ⬆️

... and 473 files with indirect coverage changes

@mch2 mch2 merged commit 0c9fc21 into opensearch-project:main Oct 26, 2023
17 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 26, 2023
Signed-off-by: Poojita Raj <[email protected]>
(cherry picked from commit 0c9fc21)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2 pushed a commit that referenced this pull request Oct 27, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logs to get the failover time for segrep enabled clusters for debugging
3 participants