Add drainRefreshes as part of tearDown in RemoteStoreRefreshListenerTests

[sachinpkale]

Description

• Acquire refresh permits before closing the IndexShard in RemoteStoreRefreshListenerTests.

Related Issues

• [BUG] Flaky org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testReplicaPromotion test #9773
• [BUG] [Remote Store] RemoteStoreRefreshListenerTests.testAfterCommit flaky test failure #8947
• [BUG] [Remote Store] testRefreshSuccessOnThirdAttemptAttempt and RemoteStoreRefreshListenerTests.testRefreshSuccessOnSecondAttempt flaky test failure #8945

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change 70d1ea8

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git]

[github-actions]

❌ Gradle check result for 445a627: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for 70d1ea8: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8dd6a0) 71.26% compared to head (70d1ea8) 71.27%.

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #12157   +/-   ##
=========================================
  Coverage     71.26%   71.27%           
+ Complexity    59413    59392   -21     
=========================================
  Files          4927     4927           
  Lines        279662   279662           
  Branches      40656    40656           
=========================================
+ Hits         199311   199328   +17     
+ Misses        63725    63723    -2     
+ Partials      16626    16611   -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sachinpkale]

Ran ./gradlew ':server:test' --tests "org.opensearch.index.shard.RemoteStoreRefreshListenerTests" 3000+ times on local without failure.