DRAFT - Do not review #1234
Closed
DRAFT - Do not review #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed c677576238168a966b5cb8999348da55ce4e0dbc |
|
✅ Gradle Wrapper Validation success c677576238168a966b5cb8999348da55ce4e0dbc |
mch2
commented
Sep 10, 2021
server/src/main/java/org/opensearch/index/translog/TranslogReader.java
Outdated
Show resolved
Hide resolved
|
Example of how this would be used here opensearch-project/cross-cluster-replication#145 |
|
❌ Gradle Precommit failure c677576238168a966b5cb8999348da55ce4e0dbc |
Extract getTranslogDeletionPolicy method so it can be overriden by subclasses and provide custom DeletionPolicies. Signed-off-by: Marc Handalian <[email protected]>
|
✅ Gradle Wrapper Validation success 39b71a0 |
|
✅ DCO Check Passed 39b71a0 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract getTranslogDeletionPolicy method so it can be overriden by subclasses and provide custom DeletionPolicies.
Signed-off-by: Marc Handalian [email protected]
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.