Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SearchRequest deepcopy method #1337

Closed
wants to merge 4 commits into from

Conversation

Da-1kun
Copy link

@Da-1kun Da-1kun commented Oct 7, 2021

Description

[Describe what this change achieves]
Added SearchRequest deep copy functionality

Issues Resolved

[List any issues this PR will resolve]
Deep copy for QueryBuilder/SearchRequest #869

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

貫 大地 added 2 commits October 7, 2021 10:54
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   DCO Check Failed 872f387
Run ./dev-tools/signoff-check.sh remotes/origin/main 872f38744f8925743bceb680e369cf98e1a980e9 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 872f387

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 872f387

2 similar comments
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 872f387

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 872f387

貫 大地 added 2 commits October 7, 2021 12:20
@opensearch-ci-bot
Copy link
Collaborator

❌   DCO Check Failed 4378c0b
Run ./dev-tools/signoff-check.sh remotes/origin/main 4378c0b643809ea0133928c8bd93e97670f12d43 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 4378c0b

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 4378c0b

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 4378c0b

@Da-1kun Da-1kun closed this Oct 7, 2021
@Da-1kun Da-1kun deleted the issue-869 branch October 7, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants