Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing org.opensearch.repositories.azure.AzureBlobContainerRetriesTests and org.opensearch.action.admin.cluster.node.stats.NodeStatsTests #1390

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Fixing org.opensearch.repositories.azure.AzureBlobContainerRetriesTests and org.opensearch.action.admin.cluster.node.stats.NodeStatsTests #1390

merged 1 commit into from
Oct 20, 2021

Conversation

reta
Copy link
Collaborator

@reta reta commented Oct 19, 2021

Description

Fixing org.opensearch.repositories.azure.AzureBlobContainerRetriesTests and org.opensearch.action.admin.cluster.node.stats.NodeStatsTests

Issues Resolved

Closes #1389 and #1388

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@reta reta mentioned this pull request Oct 19, 2021
Merged
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed d7d571438102f6178c1d59824d498f94f4ef8909

reta
reta commented Oct 19, 2021
View reviewed changes
plugins/repository-azure/build.gradle
api 'io.projectreactor.netty:reactor-netty:1.0.11'
api 'io.projectreactor.netty:reactor-netty-core:1.0.11'
api 'io.projectreactor.netty:reactor-netty-http:1.0.11'
api 'io.projectreactor:reactor-core:3.4.11'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligning with netty 4.1.69.Final

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success d7d571438102f6178c1d59824d498f94f4ef8909

reta
reta commented Oct 19, 2021
View reviewed changes
...ry-azure/src/test/java/org/opensearch/repositories/azure/AzureBlobContainerRetriesTests.java
@@ -152,7 +152,7 @@ private BlobContainer createBlobContainer(final int maxRetries) {
+ InetAddresses.toUriString(address.getAddress()) + ":" + address.getPort() + "/";
clientSettings.put(ENDPOINT_SUFFIX_SETTING.getConcreteSettingForNamespace(clientName).getKey(), endpoint);
clientSettings.put(MAX_RETRIES_SETTING.getConcreteSettingForNamespace(clientName).getKey(), maxRetries);
clientSettings.put(TIMEOUT_SETTING.getConcreteSettingForNamespace(clientName).getKey(), TimeValue.timeValueMillis(1000));
clientSettings.put(TIMEOUT_SETTING.getConcreteSettingForNamespace(clientName).getKey(), TimeValue.timeValueMillis(2000));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When CI node gets really busy, 1s may not be enough (this is total operation timeout, not network one)

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure d7d571438102f6178c1d59824d498f94f4ef8909
Log 1351

@reta
Fixing org.opensearch.repositories.azure.AzureBlobContainerRetriesTes…
d6b9bbc 
…ts and org.opensearch.action.admin.cluster.node.stats.NodeStatsTests

Signed-off-by: Andriy Redko <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success d6b9bbc

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed d6b9bbc

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success d6b9bbc

@dblock
Copy link
Member

dblock commented Oct 19, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d6b9bbc
Log 736

Reports 736

@reta
Copy link
Collaborator Author

reta commented Oct 20, 2021

❌ Gradle Check failure d6b9bbc Log 736

Reports 736

@dblock another flaky one? First time I see it, have you seen it before?

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.SharedClusterSnapshotRestoreIT.testSnapshotCanceledOnRemovedShard" -Dtests.seed=9350EB7A8335C1F9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1" -Dtests.locale=sl -Dtests.timezone=SystemV/PST8 -Druntime.java=17

org.opensearch.snapshots.SharedClusterSnapshotRestoreIT > testSnapshotCanceledOnRemovedShard FAILED
    SnapshotMissingException[[test-repo:test-snap] is missing]
        at org.opensearch.action.admin.cluster.snapshots.get.TransportGetSnapshotsAction.masterOperation(TransportGetSnapshotsAction.java:160)
        at org.opensearch.action.admin.cluster.snapshots.get.TransportGetSnapshotsAction.masterOperation(TransportGetSnapshotsAction.java:80)
        at org.opensearch.action.support.master.TransportMasterNodeAction.masterOperation(TransportMasterNodeAction.java:124)
        at org.opensearch.action.support.master.TransportMasterNodeAction$AsyncSingleAction.lambda$doStart$3(TransportMasterNodeAction.java:197)
        at org.opensearch.action.ActionRunnable$2.doRun(ActionRunnable.java:86)
        at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:792)
        at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:50)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.lang.Thread.run(Thread.java:833)

@nknize nknize mentioned this pull request Oct 20, 2021
Closed
@nknize
Copy link
Collaborator

nknize commented Oct 20, 2021

another flaky one? First time I see it...

I've seen this failure before. It's sporadic and needs deeper investigation so I opened #1396

Rerunning gradle check here...

@nknize
Copy link
Collaborator

nknize commented Oct 20, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success d6b9bbc
Log 747

Reports 747

@dblock dblock merged commit acac3cc into opensearch-project:main Oct 20, 2021
This was referenced Oct 20, 2021
Merged
Closed
@dblock dblock mentioned this pull request Apr 14, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Fix org.opensearch.action.admin.cluster.node.stats.NodeStatsTests.testSerialization (flaky)
4 participants
@reta @opensearch-ci-bot @dblock @nknize