Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pinned timestamp utils and setting to enable/disable the feature #15401

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add pinned timestamp utils and setting to enable/disable the feature #15401

merged 1 commit into from
Aug 26, 2024

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Aug 25, 2024 •
edited
Loading

Description

  • This PR adds utils related to pinned timestamp feature. As these methods are common and will be used by segment as well as translog GC, adding them in a common place is required.
  • It also adds a static setting to control enablement of remote store pinned timestamp feature.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for c4489d8: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Aug 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.93%. Comparing base (6152afe) to head (84daaba).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
.../org/opensearch/index/remote/RemoteStoreUtils.java 90.56% 2 Missing and 3 partials ⚠️
server/src/main/java/org/opensearch/node/Node.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #15401      +/-   ##
============================================
- Coverage     71.95%   71.93%   -0.02%     
- Complexity    63254    63307      +53     
============================================
  Files          5224     5224              
  Lines        296079   296137      +58     
  Branches      42763    42776      +13     
============================================
- Hits         213030   213016      -14     
- Misses        65550    65657     +107     
+ Partials      17499    17464      -35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale force-pushed the pinned-timestamp-setting branch from c4489d8 to 84daaba Compare August 25, 2024 16:55
@sachinpkale sachinpkale requested a review from jed326 as a code owner August 25, 2024 16:55
@sachinpkale sachinpkale changed the title Add setting to enable/disable remote store pinned timestamp feature Add pinned timestamp utils and setting to enable/disable the feature Aug 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 84daaba: SUCCESS

@sachinpkale sachinpkale merged commit 9014894 into opensearch-project:main Aug 26, 2024
38 of 45 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Aug 31, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 31, 2024
@github-actions
Add pinned timestamp utils and setting to enable/disable the feature (#…
d69d609 
…15401)

Signed-off-by: Sachin Kale <[email protected]>
Co-authored-by: Sachin Kale <[email protected]>
(cherry picked from commit 9014894)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 31, 2024
Merged
sachinpkale pushed a commit that referenced this pull request Aug 31, 2024
@opensearch-trigger-bot @github-actions
Add pinned timestamp utils and setting to enable/disable the feature (#…
4ea5a3b 
…15401) (#15549)

(cherry picked from commit 9014894)

Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sachin Kale <[email protected]>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
@sachinpkale @akolarkunnu
Add pinned timestamp utils and setting to enable/disable the feature (o…
627eafc 
…pensearch-project#15401)

Signed-off-by: Sachin Kale <[email protected]>
Co-authored-by: Sachin Kale <[email protected]>
This was referenced Sep 11, 2024
Open
Open
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@sachinpkale @dk2k
Add pinned timestamp utils and setting to enable/disable the feature (o…
54bd509 
…pensearch-project#15401)

Signed-off-by: Sachin Kale <[email protected]>
Co-authored-by: Sachin Kale <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@sachinpkale @dk2k
Add pinned timestamp utils and setting to enable/disable the feature (o…
fc7eb72 
…pensearch-project#15401)

Signed-off-by: Sachin Kale <[email protected]>
Co-authored-by: Sachin Kale <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@sachinpkale @dk2k
Add pinned timestamp utils and setting to enable/disable the feature (o…
79a2709 
…pensearch-project#15401)

Signed-off-by: Sachin Kale <[email protected]>
Co-authored-by: Sachin Kale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis left review comments

@linuxpi linuxpi linuxpi approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sachinpkale @dbwiddis @linuxpi