Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Upgrading gson to 2.8.9 (#1541) #1546

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

VachaShah
Copy link
Collaborator

Signed-off-by: Vacha [email protected]

Description

Backport of #1541

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 0f1eb21

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 0f1eb21

@dblock
Copy link
Member

dblock commented Nov 15, 2021

I don't think we should be backporting this into 1.2, hasn't that ship sailed?

@VachaShah
Copy link
Collaborator Author

I don't think we should be backporting this into 1.2, hasn't that ship sailed?

Backporting this to 1.2 since it is related to google/gson#1991

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 0f1eb21
Log 1087

Reports 1087

@VachaShah VachaShah added the backport PRs or issues specific to backporting features or enhancments label Nov 15, 2021
@VachaShah
Copy link
Collaborator Author

❌   Gradle Check failure 0f1eb21 Log 1087

Reports 1087

REPRODUCE WITH: ./gradlew ':distribution:tools:plugin-cli:test' --tests "org.opensearch.plugins.InstallPluginCommandTests" -Dtests.method="testOfficialPluginSnapshot {p0=com.google.common.jimfs.JimfsFileSystem@7b5b4f4d p1=org.opensearch.plugins.InstallPluginCommandTests$1Parameter$$Lambda$211/0x0000000800d72208@5ec1bf50}" -Dtests.seed=914519AA9C3BBE1F -Dtests.security.manager=false -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ru-RU -Dtests.timezone=Europe/Vaduz -Druntime.java=15
  2> java.lang.Exception: Test abandoned because suite timeout was reached.

@VachaShah
Copy link
Collaborator Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 0f1eb21
Log 1092

Reports 1092

@VachaShah VachaShah added the v1.2.0 Issues related to version 1.2.0 label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments v1.2.0 Issues related to version 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants