-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding awaitsFix to approximateRangeTest flaky tests #15601
Conversation
77d24ed
to
a413e2b
Compare
❌ Gradle check result for 77d24ed: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bharathwaj G <[email protected]>
a413e2b
to
2c682ba
Compare
❌ Gradle check result for a413e2b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15601 +/- ##
============================================
- Coverage 71.91% 71.87% -0.04%
+ Complexity 63864 63834 -30
============================================
Files 5251 5257 +6
Lines 298375 298543 +168
Branches 43146 43164 +18
============================================
+ Hits 214572 214584 +12
- Misses 66158 66297 +139
- Partials 17645 17662 +17 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15601-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a5590d1f3057c0be30765288b7efff040283d90b
# Push it to GitHub
git push --set-upstream origin backport/backport-15601-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Instead of muting these tests, we could have merged the fix for them: #15590 |
…ect#15601) Signed-off-by: Bharathwaj G <[email protected]>
…ect#15601) Signed-off-by: Bharathwaj G <[email protected]>
…ect#15601) Signed-off-by: Bharathwaj G <[email protected]>
…ect#15601) Signed-off-by: Bharathwaj G <[email protected]>
Description
Flaky test
Related Issues
Resolves #15600
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.