Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add fieldType to AbstractQueryBuilder and SortBuilder (#15328)" #15633

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

jainankitk
Copy link
Collaborator

This reverts commit 839ba0b.

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❕ Gradle check result for d1ace7c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.97%. Comparing base (eb1cbb8) to head (d1ace7c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15633      +/-   ##
============================================
+ Coverage     71.92%   71.97%   +0.04%     
- Complexity    64076    64082       +6     
============================================
  Files          5263     5263              
  Lines        299569   299522      -47     
  Branches      43303    43301       -2     
============================================
+ Hits         215467   215579     +112     
+ Misses        66391    66250     -141     
+ Partials      17711    17693      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jainankitk jainankitk merged commit a59ae3c into opensearch-project:main Sep 4, 2024
59 of 60 checks passed
@jainankitk jainankitk deleted the revert-15328 branch September 4, 2024 00:25
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants