Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Experimental gRPC transport plugin #16954

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[Backport 2.x] Experimental gRPC transport plugin #16954

merged 1 commit into from
Jan 7, 2025

Conversation

finnegancarroll
Copy link
Contributor

@finnegancarroll finnegancarroll commented Jan 6, 2025 •
edited
Loading

Backport 7a0e8fb from #16534.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ Gradle check result for c5add5f: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.19753% with 58 lines in your changes missing coverage. Please review.

Project coverage is 71.86%. Comparing base (36a02a1) to head (7bbe9bd).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...arch/transport/grpc/Netty4GrpcServerTransport.java 73.40% 18 Missing and 7 partials ⚠️
...c/main/java/org/opensearch/bootstrap/Security.java 0.00% 12 Missing ⚠️
...a/org/opensearch/common/network/NetworkModule.java 25.00% 10 Missing and 2 partials ⚠️
...java/org/opensearch/transport/grpc/GrpcPlugin.java 0.00% 4 Missing ⚠️
...g/opensearch/http/AbstractHttpServerTransport.java 33.33% 3 Missing and 1 partial ⚠️
...in/java/org/opensearch/transport/TcpTransport.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16954      +/-   ##
============================================
- Coverage     71.89%   71.86%   -0.04%     
+ Complexity    65511    65502       -9     
============================================
  Files          5314     5316       +2     
  Lines        305467   305588     +121     
  Branches      44509    44516       +7     
============================================
- Hits         219615   219596      -19     
- Misses        67545    67688     +143     
+ Partials      18307    18304       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@finnegancarroll finnegancarroll marked this pull request as ready for review January 6, 2025 18:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ Gradle check result for c5add5f: SUCCESS

@finnegancarroll
Copy link
Contributor Author

@andrross @reta

andrross
andrross previously approved these changes Jan 6, 2025
View reviewed changes
@andrross andrross dismissed their stale review January 6, 2025 20:02

Looks like the 19 commits from the original PR were brought in, as opposed to cherry picking the merged commit. Probably doesn't matter in practice but I'd prefer to cherry pick the actual merged commit and resolve conflicts.

@finnegancarroll finnegancarroll force-pushed the backport/backport-16534-to-2.x branch from c5add5f to 0a7bade Compare January 6, 2025 21:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

❌ Gradle check result for 0a7bade: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@finnegancarroll
Add gRPC server as transport-grpc plugin (opensearch-project#16534)
7bbe9bd 
Introduce auxiliary transport to NetworkPlugin and add gRPC plugin.

Auxiliary transports are optional lifecycle components provided by
network plugins which run in parallel to the http server/native
transport. They are distinct from the existing NetworkPlugin
interfaces of 'getTransports' and 'getHttpTransports' as auxiliary
transports are optional. Each AuxTransport implements it's own
'aux.transport.type' and 'aux.transport.<type>.ports' setting. Since
Security.java initializes previous to Node.java during bootstrap
socket binding permissions are granted based on
'aux.transport.<type>.ports' for each enabled 'aux.transport.type',
falling back to a default if no ports are specified.

Signed-off-by: Finn Carroll <[email protected]>
(cherry picked from commit 7a0e8fb)
@finnegancarroll finnegancarroll force-pushed the backport/backport-16534-to-2.x branch from 0a7bade to 7bbe9bd Compare January 6, 2025 21:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

❌ Gradle check result for 7bbe9bd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@finnegancarroll
Copy link
Contributor Author

org.opensearch.cluster.SpecificClusterManagerNodesIT.testElectOnlyBetweenClusterManagerNodes is flaky

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

✅ Gradle check result for 7bbe9bd: SUCCESS

@andrross andrross merged commit 8a17b8a into opensearch-project:2.x Jan 7, 2025
68 of 73 checks passed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jan 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finnegancarroll @andrross