Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] support termQueryCaseInsensitive/termQuery can search from doc_value in flat_object/keyword field #16991

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Jan 10, 2025

Description

Backport a6945d1 from #16974

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…in flat_object/keyword field

Signed-off-by: kkewwei <[email protected]>
Signed-off-by: kkewwei <[email protected]>
Copy link
Contributor

❌ Gradle check result for 637141b: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 637141b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 637141b: SUCCESS

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.86%. Comparing base (afb2f94) to head (637141b).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...rg/opensearch/index/mapper/KeywordFieldMapper.java 80.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16991      +/-   ##
============================================
+ Coverage     71.79%   71.86%   +0.06%     
- Complexity    65454    65555     +101     
============================================
  Files          5316     5316              
  Lines        305529   305544      +15     
  Branches      44509    44512       +3     
============================================
+ Hits         219359   219578     +219     
+ Misses        67902    67701     -201     
+ Partials      18268    18265       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh msfroh merged commit 37b4611 into opensearch-project:2.x Jan 10, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants