Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rename] plugins #193

Merged
merged 17 commits into from
Mar 11, 2021
Merged

[Rename] plugins #193

merged 17 commits into from
Mar 11, 2021

Conversation

harold-wang
Copy link
Contributor

@harold-wang harold-wang commented Mar 4, 2021 •
edited
Loading

Issue #160 , if available:

Description of changes:

This PR refactors files under "plugins" folder s part of the Elasticsearch to OpenSearch renaming effort.

Signed-off-by: Harold Wang [email protected]

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[Rename] Refactor ElasticSearch* class and elasticsearch* instance in…
9ffccc8 
… plugin folder, elasticsearch package name is also refactored.

Signed-off-by: Harold Wang <[email protected]>
@harold-wang harold-wang changed the base branch from main to rename/opensearch March 4, 2021 00:15
@harold-wang harold-wang changed the title [Rename] Refector plugins folder [Rename] Rename plugins folder Mar 4, 2021
@harold-wang harold-wang self-assigned this Mar 4, 2021
@harold-wang harold-wang added Rename Renaming to OpenSearch >FORK Related to the fork process labels Mar 4, 2021
@harold-wang harold-wang changed the title [Rename] Rename plugins folder [Rename] Rename files under plugins folder Mar 4, 2021
@odfe-release-bot
Copy link

Request for Admin to accept this test.

adnapibar
adnapibar suggested changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.

@harold-wang
Copy link
Contributor Author

harold-wang commented Mar 4, 2021 •
edited
Loading

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.

Done, thx.

@adnapibar
Copy link
Contributor

adnapibar commented Mar 4, 2021 •
edited by harold-wang
Loading

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.

I will put all git rename in another PR, thx.

I would say the renaming is done as part of the same PR - I don't see the point doing it separately.

Agree, it was done in same PR. thanks

@harold-wang harold-wang requested a review from adnapibar March 4, 2021 18:30
@harold-wang
Copy link
Contributor Author

harold-wang commented Mar 4, 2021 •
edited
Loading

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.

I will put the filename and directory rename in another PR, thanks
I take this suggestion, done it in the same PR.

@harold-wang
Copy link
Contributor Author

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.

I will put all git rename in another PR, thx.

I would say the renaming is done as part of the same PR - I don't see the point doing it separately.

OK, I take this suggestions, thanks.

harold-wang added 11 commits March 4, 2021 13:36
@harold-wang
Rename directory from elasticsearch to opensearch
7216f7e 
Signed-off-by: Harold Wang <[email protected]>
@harold-wang
Rename directory from elasticsearch to opensearch
4a8b670 
Signed-off-by: Harold Wang <[email protected]>
@harold-wang
Rename ESTestCase to OpenSearchTestCase
5e84bcd 
Rename ESSingleNodeTestCase to OpenSearchSingleNodeTestCase

Signed-off-by: Harold Wang <[email protected]>
@harold-wang
Rename org.elasticsearch to org.opensearch in *.gradle
1239ac7 
Signed-off-by: Harold Wang <[email protected]>
@harold-wang
Rename elasticsearch to opensearch in *.gradle
ecd89d3 
Signed-off-by: Harold Wang <[email protected]>
@harold-wang
Rename elasticsearch to opensearch
ca4c1fc 
Rename [email protected]" to "[email protected]"

Signed-off-by: Harold Wang <[email protected]>
@harold-wang
Rename "user/elasticsearch" to "user/opensearch"
249e5d4 
Signed-off-by: Harold Wang <[email protected]>
@harold-wang
Rename esplugin to opensearchplugin
40a6b17 
Rename elasticsearch to opensearch

Signed-off-by: Harold Wang <[email protected]>
@harold-wang
Rename elasticsearch to opensearch in gradle description
e31ce10 
Signed-off-by: Harold Wang <[email protected]>
@harold-wang
Rename Elasticsearch to Opensearch in description message
03fb93d 
Signed-off-by: Harold Wang <[email protected]>
@harold-wang
Rename Elasticsearch to Opensearch
f79951c 
Rename elasticsearch to opensearch

Signed-off-by: Harold Wang <[email protected]>
@harold-wang
Copy link
Contributor Author

@adnapibar @nknize @abbashus could you please help me review this one? thanks

@harold-wang
Copy link
Contributor Author

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.
Done

@harold-wang harold-wang mentioned this pull request Mar 8, 2021
Closed
@harold-wang
Copy link
Contributor Author

Please refactor the directory names along with the package names - you can use IntelliJ for renaming.

I will put all git rename in another PR, thx.

Done, thanks

@harold-wang
Merge branch 'rename/opensearch' of github.com:opendistro-for-elastic…
8c52dfc 
…search/search into rename_plugin

Signed-off-by: Harold Wang <[email protected]>
tlfeng
tlfeng reviewed Mar 10, 2021
View reviewed changes
plugins/analysis-icu/src/test/java/org/opensearch/index/analysis/IcuTokenizerFactoryTests.java Outdated Show resolved Hide resolved
plugins/examples/rest-handler/src/yamlRestTest/resources/rest-api-spec/api/cat.example.json Show resolved Hide resolved
...iscovery/gce/compute/v1/projects/nodeswithsametagsandnotagset/zones/europe-west1-b/instances
"zone": "europe-west1-b"
}
]
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just notice these 3 files with name instances are not identified as renaming, please verify that git can find the files' history.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not worry, these file is not part of version controlled file.
git mv elasticsearch opensearch
fatal: source directory is empty, source=plugins/discovery-gce/out/test/resources/org/elasticsearch, destination=plugins/discovery-gce/out/test/resources/org/opensearch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for telling me! 😄

plugins/transport-nio/src/internalClusterTest/java/org/opensearch/NioIntegTestCase.java Outdated Show resolved Hide resolved
...y-hdfs/src/test/resources/rest-api-spec/test/secure_hdfs_repository/20_repository_create.yml Show resolved Hide resolved
...gcs/src/test/java/org/opensearch/repositories/gcs/GoogleCloudStorageClientSettingsTests.java Show resolved Hide resolved
...sitory-gcs/src/test/java/org/opensearch/repositories/gcs/GoogleCloudStorageServiceTests.java Show resolved Hide resolved
plugins/repository-s3/src/main/plugin-metadata/plugin-security.policy Outdated Show resolved Hide resolved
tlfeng
tlfeng approved these changes Mar 11, 2021
View reviewed changes
Copy link
Collaborator

@tlfeng tlfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! All my comments above has been resolved.

@harold-wang harold-wang changed the title [Rename] Rename files under plugins folder [Rename] plugins Mar 11, 2021
@harold-wang harold-wang merged commit f27f5ac into opensearch-project:rename/opensearch Mar 11, 2021
nknize pushed a commit that referenced this pull request Mar 22, 2021
@harold-wang @nknize
[Rename] plugins (#193)
82f9ff9 
* [Rename] plugins (#193)

This PR refactors files under "plugins" folders part of the Elasticsearch to OpenSearch renaming effort.

Signed-off-by: Harold Wang <[email protected]>
@nknize nknize mentioned this pull request Mar 22, 2021
Closed
ritty27 pushed a commit to ritty27/OpenSearch that referenced this pull request May 12, 2024
@dblock
Extract version into gradle.properties. (opensearch-project#193)
2c30d4e 
Signed-off-by: dblock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlfeng tlfeng tlfeng approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@nknize nknize Awaiting requested review from nknize

@adnapibar adnapibar Awaiting requested review from adnapibar

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli

Assignees
No one assigned
Labels
>FORK Related to the fork process Rename Renaming to OpenSearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harold-wang @odfe-release-bot @adnapibar @tlfeng