-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using pull_request_target in place of pull_request #1952
Conversation
Can one of the admins verify this patch? |
❌ Gradle Check failure c7dc4e1b861b501c94ee765b43fd59f99d1d8780 |
Signed-off-by: Vacha Shah <[email protected]>
c7dc4e1
to
4c12405
Compare
@VachaShah thanks for this and helping me learn something new today. |
Gradle check failure:
|
start gradle check |
Could you create an issue and tag flaky tests? |
Sure! Created an issue #1957 |
Signed-off-by: Vacha Shah [email protected]
Description
Updating
pull_request
topull_request_target
to allow the permissions for the GITHUB_TOKEN because even with the permissions block added to the workflow file, the permissions in the workflow run default to read onpull_request
. Reference: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_targetIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.