Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove] index.merge.policy.max_merge_at_once_explicit #1988

Merged
merged 1 commit into from
Jan 27, 2022
Merged

[Remove] index.merge.policy.max_merge_at_once_explicit #1988

merged 1 commit into from
Jan 27, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jan 27, 2022 •
edited
Loading

Removal of deprecated parameter in #1981

Deprecated max_merge_at_once_explicit parameter is removed since it has been removed in lucene 9 and deprecated in opensearch 1.3

@nknize
[Remove] index.merge.policy.max_merge_at_once_explicit
02e251c 
deprecated max_merge_at_once_explicit parameter is removed since it has been
removed in lucene 9 and deprecated in opensearch 1.3

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize added the v2.0.0 Version 2.0.0 label Jan 27, 2022
@nknize nknize requested a review from a team as a code owner January 27, 2022 05:30
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 02e251c
Log 2087

Reports 2087

@nknize
Copy link
Collaborator Author

nknize commented Jan 27, 2022

Legit failure but unrelated to this PR. Opened #1998 to track

./gradlew ':server:test' --tests "org.opensearch.search.aggregations.bucket.composite.CompositeAggregatorTests.testWithKeywordLongAndMissingBucket" -Dtests.seed=7AEBC6A11333343F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-PY -Dtests.timezone=Pacific/Funafuti -Druntime.java=17

org.opensearch.search.aggregations.bucket.composite.CompositeAggregatorTests > testWithKeywordLongAndMissingBucket FAILED
    java.lang.AssertionError: expected:<3> but was:<4>
        at __randomizedtesting.SeedInfo.seed([7AEBC6A11333343F:9BD426C674ED5A70]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:647)
        at org.junit.Assert.assertEquals(Assert.java:633)
        at org.opensearch.search.aggregations.bucket.composite.CompositeAggregatorTests.lambda$testWithKeywordLongAndMissingBucket$93(CompositeAggregatorTests.java:1139)
        at org.opensearch.search.aggregations.bucket.composite.CompositeAggregatorTests.executeTestCase(CompositeAggregatorTests.java:2712)
        at org.opensearch.search.aggregations.bucket.composite.CompositeAggregatorTests.testSearchCase(CompositeAggregatorTests.java:2660)
        at org.opensearch.search.aggregations.bucket.composite.CompositeAggregatorTests.testWithKeywordLongAndMissingBucket(CompositeAggregatorTests.java:1128)

@nknize
Copy link
Collaborator Author

nknize commented Jan 27, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 02e251c
Log 2099

Reports 2099

adnapibar
adnapibar approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nknize nknize merged commit 5569ce0 into opensearch-project:main Jan 27, 2022
@penghuo penghuo mentioned this pull request Feb 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnapibar adnapibar adnapibar approved these changes

Assignees
No one assigned
Labels
v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nknize @opensearch-ci-bot @adnapibar