Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename modules http, index and indices under server folder #234

Closed
wants to merge 3 commits into from
Closed

Rename modules http, index and indices under server folder #234

wants to merge 3 commits into from

Conversation

harold-wang
Copy link
Contributor

Issue #160 , if available:

Description of changes:
Refactor below three modules:

. server/src/main/java/org/elasticsearch/http
. server/src/main/java/org/elasticsearch/index
. server/src/main/java/org/elasticsearch/indices

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@harold-wang
Refactor below three modules:
18df90e 
. server/src/main/java/org/elasticsearch/http
. server/src/main/java/org/elasticsearch/index
. server/src/main/java/org/elasticsearch/indices

Signed-off-by: Harold Wang <[email protected]>
@odfe-release-bot
Copy link

Request for Admin to accept this test.

@harold-wang
Rename elasticsearchVersion to opensearchVersion
8c37d23 
Rename ELASTICSEARCH to OPENSEARCH

Signed-off-by: Harold Wang <[email protected]>
@harold-wang harold-wang changed the base branch from main to rename/opensearch March 8, 2021 22:38
@adnapibar
Copy link
Contributor

adnapibar commented Mar 8, 2021 •
edited
Loading

Can you please git mv the file along with the package name change.

@harold-wang
Copy link
Contributor Author

Can you please git mv the file along with the package name change.

rename folder.

@saratvemulapalli
Copy link
Member

saratvemulapalli commented Mar 9, 2021 •
edited
Loading

Could you split this PR into 3?
Probably one for each?

. server/src/main/java/org/elasticsearch/http
. server/src/main/java/org/elasticsearch/index
. server/src/main/java/org/elasticsearch/indices

5k lines is too much to review.

tlfeng
tlfeng reviewed Mar 11, 2021
View reviewed changes
Copy link
Collaborator

@tlfeng tlfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed a huge PR, and I got a sense of endless during the review. 😂
I realized it's a grand work to make these naming changes.
Looks good, and I heard from Harold that the file paths are pending changed.

server/src/main/java/org/elasticsearch/index/analysis/PreConfiguredTokenFilter.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/FieldNamesFieldMapper.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/index/shard/ShardToolCli.java Outdated Show resolved Hide resolved
@tlfeng tlfeng mentioned this pull request Mar 11, 2021
Closed
@odfe-release-bot
Copy link

✅   DCO Check Passed

@harold-wang
Copy link
Contributor Author

This PR is replaced by other subtask.

ritty27 pushed a commit to ritty27/OpenSearch that referenced this pull request May 12, 2024
@abhinav-nath @harshavamsi
@meetesh @reta @dblock @dependabot
Add support to parse sub-aggregations from filter/nested aggregations (…
1ac790a 
…opensearch-project#234)

* Add support to parse sub-aggregations from filter/nested aggregations

Signed-off-by: Abhinav Nath <[email protected]>

* Add USER_GUIDE.md

Signed-off-by: Abhinav Nath <[email protected]>

* Add DCO

Signed-off-by: Abhinav Nath <[email protected]>

* Add link to USER_GUIDE.md in README.md

Signed-off-by: Abhinav Nath <[email protected]>

* Add changelog and changelog verifier (opensearch-project#239)

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Abhinav Nath <[email protected]>

* Set javadoc encoding to utf-8 (opensearch-project#50) (opensearch-project#241)

Signed-off-by: Meetesh Kumawat<[email protected]>
Signed-off-by: meetesh <[email protected]>

Signed-off-by: Meetesh Kumawat<[email protected]>
Signed-off-by: meetesh <[email protected]>
Signed-off-by: Abhinav Nath <[email protected]>

* Update Jackson Databind to 2.13.4.2 (addressing CVE-2022-42003) (opensearch-project#240)

Signed-off-by: Andriy Redko <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Abhinav Nath <[email protected]>

* Updates changelog for dependabot PRs (opensearch-project#247)

* Updates changelog for dependabot PRs

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Adding dependabot label for workflow

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Abhinav Nath <[email protected]>

* Update tests to use JUnit's Assert (opensearch-project#244)

Signed-off-by: Andriy Redko <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Abhinav Nath <[email protected]>

* Update literature around changelog (opensearch-project#242)

* Update literature

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Removing pr template and updating language

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: Abhinav Nath <[email protected]>

* Bump grgit-gradle from 4.0.1 to 5.0.0 (opensearch-project#243)

* Bump grgit-gradle from 4.0.1 to 5.0.0

Bumps [grgit-gradle](https://github.com/ajoberstar/grgit) from 4.0.1 to 5.0.0.
- [Release notes](https://github.com/ajoberstar/grgit/releases)
- [Commits](ajoberstar/grgit@4.0.1...5.0.0)

---
updated-dependencies:
- dependency-name: org.ajoberstar.grgit:grgit-gradle
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: Abhinav Nath <[email protected]>

* Add DCO

Signed-off-by: Abhinav Nath <[email protected]>

* Update CHANGELOG and README

Signed-off-by: Abhinav Nath <[email protected]>

* Add DCO

Signed-off-by: Abhinav Nath <[email protected]>

* Add DCO

Signed-off-by: Abhinav Nath <[email protected]>

* Fix CHANGLOG and README TOC

Signed-off-by: Abhinav Nath <[email protected]>

Signed-off-by: Abhinav Nath <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Meetesh Kumawat<[email protected]>
Signed-off-by: meetesh <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Harsha Vamsi Kalluri <[email protected]>
Co-authored-by: Meetesh Kumawat <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlfeng tlfeng tlfeng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harold-wang @odfe-release-bot @adnapibar @saratvemulapalli @tlfeng