-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename reference to project OpenSearch was forked from #2483
Rename reference to project OpenSearch was forked from #2483
Conversation
❌ Gradle Check failure 5bfdeb86d89a88ce0072bca7b3a0e930a59246da |
5bfdeb8
to
70930fc
Compare
❌ Gradle Check failure 70930fc1502d3f25424f27b9c06456797d23fea4 |
Failed due to
Flaky test? |
Fixing log message and renaming internal variable. Improving internal JavaDoc. Signed-off-by: Lukáš Vlček <[email protected]>
70930fc
to
f636986
Compare
Looks like another flaky test? (below is excerpt from gradle_check_3444.log):
This test passes on my local machine (but I do not have the same HW setup):
|
@lukas-vlcek for flakey tests, add a link to an existing issue for the same failure to this PR/log, or open a new one please |
start gradle check |
@dblock @lukas-vlcek the cause of the failure is not the flaky one, it is directly coming from changes in Lucene 9 (same as cause as NumberFieldTypeTests fe)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thx for this cleanup!
Description
Fixing log message and renaming internal variable.
Improving internal JavaDoc.
Issues Resolved
Hidden forking and rename leftover that was making it into log message.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Lukáš Vlček [email protected]