[DOCS] Replace 'elasticsearch' that used as plain text in the code snippets #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 9, 2021 15:27
This reverts commit f6bbcd3
…ggregation examples
|
Request for Admin to accept this test. |
added 3 commits
March 9, 2021 22:04
tlfeng
added
documentation
setiah
reviewed
Mar 14, 2021
| @@ -321,6 +321,7 @@ buildRestTests.doFirst { | |||
| buildRestTests.setups['bank'].replace('#bank_data#', accounts) | |||
| } | |||
|
|
|||
| // TODO: Replace the setup code of 'stackoverflow' and 'news' for OpenSearch | |||
There was a problem hiding this comment.
TODO(OpenSearch) instead?
There was a problem hiding this comment.
Sure, it's a good idea! I will replace TODO with TODO(OpenSearch), and simplify the message after the colon:
setiah
suggested changes
Mar 14, 2021
|
❌ DCO Check Failed |
|
I will continue the work in PR #367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#238
Description of changes:
The PR requests merging the code into
oss-docsbranch.elasticsearch,Elasticsearchthat used as plain text in code snippetselasticsearchindocs/build.graldethat used to generate data for the code snippet testselasticsearchkeywords can be replaced easilyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.