Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace remaining 'blacklist' with 'denylist' in internal class and method names #2784

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Apr 6, 2022

Description

This is the last PR for replacing non-inclusive terminology blacklist.
Most of the internal usages of non-inclusive terminology blacklist/whitelist was replaced by PR #2178, while there are a few remaining.

  • Replace blacklist with denylist in internal class and method names.

Note:

  1. The 2 classes to be renamed are not published to Maven
  1. The package org.opensearch.common.inject is a forked version of Google Guice framework 2.0 (elastic/elasticsearch@2a19160), and the blacklist terminology in Guice code was also been replaced in the commit google/guice@3d98f86

Issues Resolved

resolve #1484

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 7adeafb
Log 4244

Reports 4244

@tlfeng tlfeng added v2.1.0 Issues and PRs related to version 2.1.0 v3.0.0 Issues and PRs related to version 3.0.0 backport 2.x Backport to 2.x branch labels Apr 6, 2022
@tlfeng tlfeng marked this pull request as ready for review April 6, 2022 04:09
@tlfeng tlfeng requested a review from a team as a code owner April 6, 2022 04:09
@tlfeng tlfeng added v2.0.0 Version 2.0.0 backport 2.0 Backport to 2.0 branch and removed v2.1.0 Issues and PRs related to version 2.1.0 labels Apr 6, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success d46d147
Log 4245

Reports 4245

@tlfeng tlfeng changed the title Replace 'blacklist' with 'denylist' in remaining internal class and method names Replace remaining 'blacklist' with 'denylist' in internal class and method names Apr 6, 2022
@saratvemulapalli saratvemulapalli merged commit 47a22bb into opensearch-project:main Apr 7, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 7, 2022
…ethod names (#2784)

* Replace blacklist with denylist in BlacklistedPathPatternMatcher

Signed-off-by: Tianli Feng <[email protected]>

* Replace blacklist with denylist in assumption message

Signed-off-by: Tianli Feng <[email protected]>

* Replace all Blacklisted with Denylisted

Signed-off-by: Tianli Feng <[email protected]>

* Replace all blacklist(key) with denylist(key)

Signed-off-by: Tianli Feng <[email protected]>

* Adjust format by spotlessApply task

Signed-off-by: Tianli Feng <[email protected]>
(cherry picked from commit 47a22bb)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 7, 2022
…ethod names (#2784)

* Replace blacklist with denylist in BlacklistedPathPatternMatcher

Signed-off-by: Tianli Feng <[email protected]>

* Replace blacklist with denylist in assumption message

Signed-off-by: Tianli Feng <[email protected]>

* Replace all Blacklisted with Denylisted

Signed-off-by: Tianli Feng <[email protected]>

* Replace all blacklist(key) with denylist(key)

Signed-off-by: Tianli Feng <[email protected]>

* Adjust format by spotlessApply task

Signed-off-by: Tianli Feng <[email protected]>
(cherry picked from commit 47a22bb)
@tlfeng tlfeng deleted the replace-blacklist-internal-last branch April 8, 2022 00:20
tlfeng pushed a commit that referenced this pull request Apr 8, 2022
…ethod names (#2784) (#2812)

This is the last commit for replacing non-inclusive terminology `blacklist`. 
Most of the internal usages of non-inclusive terminology `blacklist/whitelist` was replaced by PR #2178, while there are a few remaining.
- Replace `blacklist` with `denylist` in internal class and method names.


Signed-off-by: Tianli Feng <[email protected]>
(cherry picked from commit 47a22bb)
tlfeng pushed a commit that referenced this pull request Apr 8, 2022
…ethod names (#2784) (#2813)

This is the last commit for replacing non-inclusive terminology `blacklist`. 
Most of the internal usages of non-inclusive terminology `blacklist/whitelist` was replaced by PR #2178, while there are a few remaining.
- Replace `blacklist` with `denylist` in internal class and method names.


Signed-off-by: Tianli Feng <[email protected]>
(cherry picked from commit 47a22bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch Severity-Minor v2.0.0 Version 2.0.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "blacklist/whitelist" terminology in code comments, and internal variable, method and class names
5 participants