Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use G1GC on JDK11+ #2964

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Use G1GC on JDK11+ #2964

merged 1 commit into from
Apr 19, 2022

Conversation

mattweber
Copy link
Contributor

Update default jvm settings to use G1GC by default for
JDK11 and greater.

Issues Resolved

#2916

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mattweber
Use G1GC on JDK11+
c30c68c 
Update default jvm settings to use G1GC by default for
JDK11 and greater.

Signed-off-by: Matt Weber <[email protected]>
@mattweber mattweber requested a review from a team as a code owner April 18, 2022 21:26
@mattweber
Copy link
Contributor Author

cc @reta @nknize

@reta
Copy link
Collaborator

reta commented Apr 18, 2022

@dblock FYI, please

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success c30c68c
Log 4599

Reports 4599

nknize
nknize approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nknize nknize merged commit 8bfb082 into opensearch-project:main Apr 19, 2022
@mattweber
Copy link
Contributor Author

Thanks @nknize, can this be auto-backported or should I open some backport PRs?

@nknize nknize added backport 1.x backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch backport 1.3 Backport to 1.3 branch Build Libraries & Interfaces labels Apr 19, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2022
@mattweber @github-actions
Use G1GC on JDK11+ (#2964)
e875145 
Update default jvm settings to use G1GC by default for
JDK11 and greater.

Signed-off-by: Matt Weber <[email protected]>
(cherry picked from commit 8bfb082)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 19, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2022
@mattweber @github-actions
Use G1GC on JDK11+ (#2964)
8e5d515 
Update default jvm settings to use G1GC by default for
JDK11 and greater.

Signed-off-by: Matt Weber <[email protected]>
(cherry picked from commit 8bfb082)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 19, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2022
@mattweber @github-actions
Use G1GC on JDK11+ (#2964)
1665478 
Update default jvm settings to use G1GC by default for
JDK11 and greater.

Signed-off-by: Matt Weber <[email protected]>
(cherry picked from commit 8bfb082)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 19, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2022
@mattweber @github-actions
Use G1GC on JDK11+ (#2964)
f4619b0 
Update default jvm settings to use G1GC by default for
JDK11 and greater.

Signed-off-by: Matt Weber <[email protected]>
(cherry picked from commit 8bfb082)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 19, 2022
Merged
@dblock
Copy link
Member

dblock commented Apr 19, 2022

Thanks. This was a miss for 1.3. I think we should release the next 1.3.x given this regression.

dblock pushed a commit that referenced this pull request Apr 19, 2022
@opensearch-trigger-bot @mattweber
Use G1GC on JDK11+ (#2964) (#2973)
13116d2 
Update default jvm settings to use G1GC by default for
JDK11 and greater.

Signed-off-by: Matt Weber <[email protected]>
(cherry picked from commit 8bfb082)

Co-authored-by: Matt Weber <[email protected]>
dblock pushed a commit that referenced this pull request Apr 19, 2022
@opensearch-trigger-bot @mattweber
Use G1GC on JDK11+ (#2964) (#2970)
e9ad634 
Update default jvm settings to use G1GC by default for
JDK11 and greater.

Signed-off-by: Matt Weber <[email protected]>
(cherry picked from commit 8bfb082)

Co-authored-by: Matt Weber <[email protected]>
dblock pushed a commit that referenced this pull request Apr 19, 2022
@opensearch-trigger-bot @mattweber
Use G1GC on JDK11+ (#2964) (#2971)
3571eab 
Update default jvm settings to use G1GC by default for
JDK11 and greater.

Signed-off-by: Matt Weber <[email protected]>
(cherry picked from commit 8bfb082)

Co-authored-by: Matt Weber <[email protected]>
dblock pushed a commit that referenced this pull request Apr 19, 2022
@opensearch-trigger-bot @mattweber
Use G1GC on JDK11+ (#2964) (#2972)
5a09006 
Update default jvm settings to use G1GC by default for
JDK11 and greater.

Signed-off-by: Matt Weber <[email protected]>
(cherry picked from commit 8bfb082)

Co-authored-by: Matt Weber <[email protected]>
@dblock
Copy link
Member

dblock commented Apr 19, 2022

Looks like all the backports succeeded and were merged. Thanks for your help @mattweber.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

@reta reta reta approved these changes

Assignees
No one assigned
Labels
backport 1.x backport 1.3 Backport to 1.3 branch backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch Build Libraries & Interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattweber @reta @opensearch-ci-bot @dblock @nknize