[Rename] refactor more of o.e.search package in the server module. #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed |
|
❌ DCO Check Failed |
tlfeng
approved these changes
Mar 15, 2021
|
|
||
| import java.io.IOException; | ||
| import java.util.Locale; | ||
| import java.util.Objects; | ||
| import java.util.function.Consumer; | ||
|
|
||
| public final class DirectCandidateGeneratorBuilder implements CandidateGenerator { | ||
| public final class DirectCandidateGeneratorBuilder implements PhraseSuggestionBuilder.CandidateGenerator { |
There was a problem hiding this comment.
Minor: Seems an unexpected change.
There was a problem hiding this comment.
Resolved, thanks!
As part of this commit we refactor the following in the o.e.search package: - rename `org.elasticsearch.search.fetch` to `org.opensearch.search.fetch` - rename `org.elasticsearch.search.internal` to `org.opensearch.search.internal` - rename `org.elasticsearch.search.profile` to `org.opensearch.search.profile` - rename `org.elasticsearch.search.query` to `org.opensearch.search.query` - rename `org.elasticsearch.search.suggest` to `org.opensearch.search.suggest` - rename other instances of Elasticsearch to OpenSearch in these packages. Signed-off-by: Rabi Panda <[email protected]>
|
✅ DCO Check Passed |
nknize
pushed a commit
that referenced
this pull request
Mar 20, 2021
) As part of this commit we refactor the following in the o.e.search package: - rename `org.elasticsearch.search.fetch` to `org.opensearch.search.fetch` - rename `org.elasticsearch.search.internal` to `org.opensearch.search.internal` - rename `org.elasticsearch.search.profile` to `org.opensearch.search.profile` - rename `org.elasticsearch.search.query` to `org.opensearch.search.query` - rename `org.elasticsearch.search.suggest` to `org.opensearch.search.suggest` - rename other instances of Elasticsearch to OpenSearch in these packages. Signed-off-by: Rabi Panda <[email protected]>
nknize
pushed a commit
that referenced
this pull request
Mar 22, 2021
) As part of this commit we refactor the following in the o.e.search package: - rename `org.elasticsearch.search.fetch` to `org.opensearch.search.fetch` - rename `org.elasticsearch.search.internal` to `org.opensearch.search.internal` - rename `org.elasticsearch.search.profile` to `org.opensearch.search.profile` - rename `org.elasticsearch.search.query` to `org.opensearch.search.query` - rename `org.elasticsearch.search.suggest` to `org.opensearch.search.suggest` - rename other instances of Elasticsearch to OpenSearch in these packages. Signed-off-by: Rabi Panda <[email protected]>
ritty27
pushed a commit
to ritty27/OpenSearch
that referenced
this pull request
May 12, 2024
…oject#306) * make ChildrenAggregate as a SingleBucketAggregate Signed-off-by: Siva <[email protected]> * update CHANGELOG.md Signed-off-by: Siva <[email protected]> * add ChildAggregation test Signed-off-by: Siva <[email protected]> * fix CheckStyle violations for ChildAggregation test Signed-off-by: Siva <[email protected]> Signed-off-by: Siva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #160
As part of this commit we refactor the following in the o.e.search package:
org.elasticsearch.search.internaltoorg.opensearch.search.internalorg.elasticsearch.search.fetchtoorg.opensearch.search.fetchorg.elasticsearch.search.profiletoorg.opensearch.search.profileorg.elasticsearch.search.querytoorg.opensearch.search.queryorg.elasticsearch.search.suggesttoorg.opensearch.search.suggestSigned-off-by: Rabi Panda [email protected]