Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Javadocs] Add to o.o.disovery, env, gateway, http, ingest, lucene and node pkgs #3187

Merged
merged 1 commit into from
May 5, 2022
Merged

[Backport 2.x] [Javadocs] Add to o.o.disovery, env, gateway, http, ingest, lucene and node pkgs #3187

merged 1 commit into from
May 5, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 4d3da00 from #3185

@nknize @github-actions
[Javadocs] Add to o.o.disovery, env, gateway, http, ingest, lucene an…
4fe8e2a 
…d node pkgs (#3185)

Adds javadocs to classes in the org.opensearch.discovery, env, gateway, http,
ingest, lucene, and node packages.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit 4d3da00)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner May 4, 2022 19:33
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 4fe8e2a
Log 5004

Reports 5004

@kartg
Copy link
Member

kartg commented May 4, 2022

@nknize seems like a mismatch between your Git name and your Github name:

Expected "Nick Knize ... but got "Nicholas Walter Knize ...."

@nknize
Copy link
Collaborator

nknize commented May 5, 2022

Yeah. For my gpg key, git user.name has to match what I registered in the Apache keyserver. As a result user.name is also what ends up being used in DCO. I don't want to change my GitHub display name to match; and contributors shouldn't have to. They should be able to use a shortened GitHub display name that doesn't have to match the user.name variable in DCO.

TODO: We should update the backport action to use the same DCO as the original commit instead of pulling from GitHub.

@dblock
Copy link
Member

dblock commented May 5, 2022

@nknize Can you please open issues for the DCO workflow to be fixed in this case?

In the meantime we're stuck to always have to go and click "set DCO to pass" button, which is a burden for the code reviewers.

@dblock dblock merged commit 5f19df1 into 2.x May 5, 2022
@github-actions github-actions bot deleted the backport/backport-3185-to-2.x branch May 5, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@kartg kartg kartg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@opensearch-ci-bot @kartg @nknize @dblock @reta