-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] refactor modules/kibana. #334
[Rename] refactor modules/kibana. #334
Conversation
✅ DCO Check Passed |
...oards/src/javaRestTest/java/org/opensearch/dashboards/OpenSearchDashboardsSystemIndexIT.java
Outdated
Show resolved
Hide resolved
...oards/src/javaRestTest/java/org/opensearch/dashboards/OpenSearchDashboardsSystemIndexIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some comments that should help with the kibana specific renaming. The comments should be applied to the entire PR since I did not comment on every occurrence
...oards/src/javaRestTest/java/org/opensearch/dashboards/OpenSearchDashboardsSystemIndexIT.java
Outdated
Show resolved
Hide resolved
modules/dashboards/src/main/java/org/opensearch/dashboards/OpenSearchDashboardsPlugin.java
Outdated
Show resolved
Hide resolved
✅ DCO Check Passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...oards/src/javaRestTest/java/org/opensearch/dashboards/OpenSearchDashboardsSystemIndexIT.java
Show resolved
Hide resolved
...oards/src/javaRestTest/java/org/opensearch/dashboards/OpenSearchDashboardsSystemIndexIT.java
Outdated
Show resolved
Hide resolved
...pensearch-dashboards/src/main/java/org/opensearch/dashboards/OpenSearchDashboardsPlugin.java
Show resolved
Hide resolved
...arch-dashboards/src/test/java/org/opensearch/dashboards/OpenSearchDashboardsPluginTests.java
Show resolved
Hide resolved
...arch-dashboards/src/test/java/org/opensearch/dashboards/OpenSearchDashboardsPluginTests.java
Outdated
Show resolved
Hide resolved
Refactor the the module `modules/kibana` to - rename package names`org.elasticsearch.kibana` to `org.opensearch.dashboards` in package names and references. - rename other instances of Kibana to OpenSearchDashboards Signed-off-by: Rabi Panda <[email protected]>
✅ DCO Check Passed |
Signed-off-by: Rabi Panda <[email protected]>
✅ DCO Check Passed |
Refactor the the module `modules/kibana` to - rename package names`org.elasticsearch.kibana` to `org.opensearch.dashboards` in package names and references. - rename other instances of Kibana to OpenSearchDashboards Signed-off-by: Rabi Panda <[email protected]>
Refactor the the module `modules/kibana` to - rename package names`org.elasticsearch.kibana` to `org.opensearch.dashboards` in package names and references. - rename other instances of Kibana to OpenSearchDashboards Signed-off-by: Rabi Panda <[email protected]>
Signed-off-by: dblock <[email protected]> Signed-off-by: dblock <[email protected]>
Relates #160
Refactor the the module
modules/kibana
toorg.elasticsearch.kibana
toorg.opensearch.dashboards
in package names and references.Signed-off-by: Rabi Panda [email protected]