-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] o.e.common.settings #336
Merged
nknize
merged 3 commits into
opensearch-project:rename/opensearch
from
nknize:rename/server/common/settings
Mar 17, 2021
Merged
[Rename] o.e.common.settings #336
nknize
merged 3 commits into
opensearch-project:rename/opensearch
from
nknize:rename/server/common/settings
Mar 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ DCO Check Passed |
nknize
force-pushed
the
rename/server/common/settings
branch
from
March 16, 2021 21:21
da98c4f
to
4adb618
Compare
✅ DCO Check Passed |
nknize
force-pushed
the
rename/server/common/settings
branch
from
March 16, 2021 22:18
4adb618
to
16812b7
Compare
✅ DCO Check Passed |
nknize
force-pushed
the
rename/server/common/settings
branch
from
March 16, 2021 22:47
16812b7
to
13ec14e
Compare
✅ DCO Check Passed |
tlfeng
reviewed
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purely class path changes, and no suspicious "import" were going to be added. 🙂
server/src/main/java/org/opensearch/action/admin/indices/create/CreateIndexRequest.java
Outdated
Show resolved
Hide resolved
nknize
force-pushed
the
rename/server/common/settings
branch
from
March 17, 2021 07:16
13ec14e
to
1466c3f
Compare
✅ DCO Check Passed |
1 similar comment
✅ DCO Check Passed |
This commit refactors o.e.common.settings package to the o.opensearch.common.setttings namespace. All references throughout the codebase are refactored. Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
nknize
force-pushed
the
rename/server/common/settings
branch
from
March 17, 2021 07:32
fe707b4
to
05c6d20
Compare
✅ DCO Check Passed |
tlfeng
approved these changes
Mar 17, 2021
nknize
added a commit
that referenced
this pull request
Mar 20, 2021
This commit refactors o.e.common.settings package to the o.opensearch.common.setttings namespace. All references throughout the codebase are refactored. Signed-off-by: Nicholas Walter Knize <[email protected]>
nknize
added a commit
that referenced
this pull request
Mar 22, 2021
This commit refactors o.e.common.settings package to the o.opensearch.common.setttings namespace. All references throughout the codebase are refactored. Signed-off-by: Nicholas Walter Knize <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors o.e.common.settings package to the
o.opensearch.common.setttings namespace. All references throughout the codebase
are refactored.
relates #160