-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opensearch gradle check migration to public jenkins (Old) #3698
Opensearch gradle check migration to public jenkins (Old) #3698
Conversation
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Seems like github action have trouble reading from github secret, it is not stable for today anyway. |
jobs: | ||
gradle_check: | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 130 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are we deciding the timeout here to be 130? Did we document it somewhere?
JENKINS_URL="https://build.ci.opensearch.org" | ||
WORKFLOW_NAME="gradle_check" | ||
TIMEPASS=0 | ||
TIMEOUT=7200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Instead of closing this PR. Can we keep it in the draft state? |
TIMEOUT=7200 | ||
RESULT="null" | ||
|
||
echo "Trigger Jenkins workflows" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there a Jenkins CLI to do this and avoid having to hand roll the entire request/wait/response flow?
java -jar jenkins-cli.jar ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even better, https://github.com/toptal/jenkins-job-trigger-action seems to do the same thing?
https://github.com/marketplace/actions/trigger-jenkins-job
Description
Opensearch gradle check migration to public jenkins
Issues Resolved
opensearch-project/opensearch-build#851
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.