Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Add gradle check test for github workflows (Testing again) #3724

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

[Backport 1.x] Add gradle check test for github workflows (Testing again)

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added the enhancement Enhancement or improvement to existing feature or request label Jun 28, 2022
@peterzhuamazon peterzhuamazon requested a review from CEHENKLE June 28, 2022 00:05
@peterzhuamazon peterzhuamazon self-assigned this Jun 28, 2022
@peterzhuamazon peterzhuamazon changed the base branch from main to 1.x June 28, 2022 00:05
@peterzhuamazon peterzhuamazon marked this pull request as ready for review June 28, 2022 00:07
@peterzhuamazon
Copy link
Member Author

@CEHENKLE Jenkins Gradle Check is expected to fail as it could not read secret as the initial file addition is coming from my fork not the core repo branch directly.

Thanks.

Signed-off-by: Peter Zhu <[email protected]>
@CEHENKLE CEHENKLE merged commit 60f3e5b into opensearch-project:1.x Jun 28, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-gradle-check-1.x branch June 28, 2022 00:29
mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Jul 5, 2022
…ain) (opensearch-project#3724)

* [Backport 1.x] Add gradle check test for github workflows (Testing again)

* [Backport 1.x] Add gradle check test for github workflows (Testing again)

Signed-off-by: Peter Zhu <[email protected]>

* Remove linter

Signed-off-by: Peter Zhu <[email protected]>
mch2 added a commit that referenced this pull request Jul 6, 2022
* [Backport 1.x] Add gradle check test for github workflows (Testing again) (#3724)

* [Backport 1.x] Add gradle check test for github workflows (Testing again)

* [Backport 1.x] Add gradle check test for github workflows (Testing again)

Signed-off-by: Peter Zhu <[email protected]>

* Remove linter

Signed-off-by: Peter Zhu <[email protected]>

* Update github action gradle-check to use pull_request_target for accessing token (#3728) (#3730)

* Check out gradle

Signed-off-by: Peter Zhu <[email protected]>

* Tweak titles

Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 4f7bf08)

Co-authored-by: Peter Zhu <[email protected]>

* Move gradle-check code to its own scripts and upload codecov (#3742) (#3744)

* Move gradle-check to script, add codecov, add comments

Signed-off-by: Peter Zhu <[email protected]>

* Add more improvements on comments handling

Signed-off-by: Peter Zhu <[email protected]>

* Add more comments

Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 3681ac7)

Co-authored-by: Peter Zhu <[email protected]>

Co-authored-by: Peter Zhu <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants