Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic thorttler/exponential backoff policy for retry/Defination of throttling exception #3856

Conversation

dhwanilpatel
Copy link
Contributor

Add basic thorttler/exponential backoff policy for retry/Defination of throttling exception

Signed-off-by: Dhwanil Patel [email protected]

Description

Reopening PR(#3527) against feature branch (feature/master-task-throttling).

[NOTE] : For review comments please visit older PR.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dhwanilpatel dhwanilpatel requested review from a team and reta as code owners July 12, 2022 05:23
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dhwanilpatel
Copy link
Contributor Author

Gradle check fails with:

WorkflowScript: 134: Arguments to "junit" must be explicitly named. @ line 134, column 21.
                       junit allowEmptyResults: true, '**/build/test-results/**/*.xml'

Waiting for fix(opensearch-project/opensearch-build#2328) in build to be merged.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock dblock requested a review from Bukhtawar July 12, 2022 12:20
@dblock
Copy link
Member

dblock commented Jul 12, 2022

@Bukhtawar want to take on CRing this?

@dblock
Copy link
Member

dblock commented Jul 12, 2022

Should we just merge this? Goes on a feature branch. @reta your call

@reta
Copy link
Collaborator

reta commented Jul 12, 2022

Should we just merge this? Goes on a feature branch. @reta your call

I think so, we reviewed and approved the original one

@reta reta merged commit 7ac6c8d into opensearch-project:feature/master-task-throttling Jul 12, 2022
@dblock
Copy link
Member

dblock commented Jul 12, 2022

Thanks for your help @reta!

dhwanilpatel added a commit to dhwanilpatel/OpenSearch-1 that referenced this pull request Nov 2, 2022
…f throttling exception (opensearch-project#3856)

* Add basic thorttler/exponential backoff policy for retry/Defination of throttling exception

Signed-off-by: Dhwanil Patel <[email protected]>

* Incorporated comments

Signed-off-by: Dhwanil Patel <[email protected]>

* Incorporated minor comments

Signed-off-by: Dhwanil Patel <[email protected]>

* Removed overall thorttlingEnabled flag from Throttler

Signed-off-by: Dhwanil Patel <[email protected]>

* Corrected Java doc for Throttler

Signed-off-by: Dhwanil Patel <[email protected]>

* Incorporated comments

Signed-off-by: Dhwanil Patel <[email protected]>

* Changed the default behaviour of Throttler to return Optional

Signed-off-by: Dhwanil Patel <[email protected]>

* Removed generics from Throttler and used String as key

Signed-off-by: Dhwanil Patel <[email protected]>

* Ignore backport / autocut / dependabot branches for gradle checks on push

Signed-off-by: Peter Zhu <[email protected]>

Co-authored-by: Peter Zhu <[email protected]>
Bukhtawar pushed a commit that referenced this pull request Nov 4, 2022
* Add basic thorttler/exponential backoff policy for retry/Defination of throttling exception (#3856)

* Corrected Java doc for Throttler

* Changed the default behaviour of Throttler to return Optional

* Removed generics from Throttler and used String as key

* Ignore backport / autocut / dependabot branches for gradle checks on push

* Master node changes for master task throttling (#3882)

* Data node changes for master task throttling (#4204)

* Onboarding of few task types to throttling (#4542)

* Fix timeout exception and Add Integ test for Master task throttling (#4588)

* Complete TODO for version change and removed unused classes(Throttler and Semaphore) (#4846)

* Remove V1 version from throttling testcase

Signed-off-by: Dhwanil Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants