-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic thorttler/exponential backoff policy for retry/Defination of throttling exception #3856
Merged
reta
merged 12 commits into
opensearch-project:feature/master-task-throttling
from
dhwanilpatel:throttling-pr-1
Jul 12, 2022
Merged
Add basic thorttler/exponential backoff policy for retry/Defination of throttling exception #3856
reta
merged 12 commits into
opensearch-project:feature/master-task-throttling
from
dhwanilpatel:throttling-pr-1
Jul 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f throttling exception Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: Dhwanil Patel <[email protected]>
…push Signed-off-by: Peter Zhu <[email protected]>
…' into throttling-pr-1 Signed-off-by: Dhwanil Patel <[email protected]>
Signed-off-by: Dhwanil Patel <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
5 tasks
Gradle check fails with:
Waiting for fix(opensearch-project/opensearch-build#2328) in build to be merged. |
Gradle Check (Jenkins) Run Completed with:
|
@Bukhtawar want to take on CRing this? |
reta
approved these changes
Jul 12, 2022
Should we just merge this? Goes on a feature branch. @reta your call |
I think so, we reviewed and approved the original one |
Thanks for your help @reta! |
dhwanilpatel
added a commit
to dhwanilpatel/OpenSearch-1
that referenced
this pull request
Nov 2, 2022
…f throttling exception (opensearch-project#3856) * Add basic thorttler/exponential backoff policy for retry/Defination of throttling exception Signed-off-by: Dhwanil Patel <[email protected]> * Incorporated comments Signed-off-by: Dhwanil Patel <[email protected]> * Incorporated minor comments Signed-off-by: Dhwanil Patel <[email protected]> * Removed overall thorttlingEnabled flag from Throttler Signed-off-by: Dhwanil Patel <[email protected]> * Corrected Java doc for Throttler Signed-off-by: Dhwanil Patel <[email protected]> * Incorporated comments Signed-off-by: Dhwanil Patel <[email protected]> * Changed the default behaviour of Throttler to return Optional Signed-off-by: Dhwanil Patel <[email protected]> * Removed generics from Throttler and used String as key Signed-off-by: Dhwanil Patel <[email protected]> * Ignore backport / autocut / dependabot branches for gradle checks on push Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
Bukhtawar
pushed a commit
that referenced
this pull request
Nov 4, 2022
* Add basic thorttler/exponential backoff policy for retry/Defination of throttling exception (#3856) * Corrected Java doc for Throttler * Changed the default behaviour of Throttler to return Optional * Removed generics from Throttler and used String as key * Ignore backport / autocut / dependabot branches for gradle checks on push * Master node changes for master task throttling (#3882) * Data node changes for master task throttling (#4204) * Onboarding of few task types to throttling (#4542) * Fix timeout exception and Add Integ test for Master task throttling (#4588) * Complete TODO for version change and removed unused classes(Throttler and Semaphore) (#4846) * Remove V1 version from throttling testcase Signed-off-by: Dhwanil Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic thorttler/exponential backoff policy for retry/Defination of throttling exception
Signed-off-by: Dhwanil Patel [email protected]
Description
Reopening PR(#3527) against feature branch (feature/master-task-throttling).
[NOTE] : For review comments please visit older PR.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.