Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TESTING.asciidoc udpate #390

Merged
merged 4 commits into from
Mar 19, 2021
Merged

TESTING.asciidoc udpate #390

merged 4 commits into from
Mar 19, 2021

Conversation

stockholmux
Copy link
Member

Updated TESTING to reflect current naming, paths, and parameters

@odfe-release-bot
Copy link

✅   DCO Check Passed

@adnapibar adnapibar mentioned this pull request Mar 19, 2021
Closed
saratvemulapalli
saratvemulapalli reviewed Mar 19, 2021
View reviewed changes
TESTING.asciidoc Outdated
- In order to set a different keystore password: `--keystore-password`
- In order to set an Elasticsearch setting, provide a setting with the following prefix: `-Dtests.es.`
- In order to set a different keystore password: `--keystore-password yourpassword`
- In order to set an OpenSearch setting, provide a setting with the following prefix: `-Dtests.es.`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably rename es to opensearch..

Suggested change
- In order to set an OpenSearch setting, provide a setting with the following prefix: `-Dtests.es.`
- In order to set an OpenSearch setting, provide a setting with the following prefix: `-Dtests.opensearch.`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A probably source 😉:

OpenSearch/buildSrc/src/main/java/org/opensearch/gradle/testclusters/RunTask.java

Line 45 in 5148cfa

public static final String CUSTOM_SETTINGS_PREFIX = "tests.opensearch.";

saratvemulapalli
saratvemulapalli approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look good to me!

tlfeng
tlfeng reviewed Mar 19, 2021
View reviewed changes
TESTING.asciidoc Outdated Show resolved Hide resolved
tlfeng
tlfeng reviewed Mar 19, 2021
View reviewed changes
TESTING.asciidoc Outdated Show resolved Hide resolved
tlfeng
tlfeng reviewed Mar 19, 2021
View reviewed changes
TESTING.asciidoc Outdated Show resolved Hide resolved
@odfe-release-bot
Copy link

❌   DCO Check Failed
Run ./dev-tools/signoff-check.sh remotes/origin/main 90a5a1e6874d6558eb1dfebbc2add3e51beb379f to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@odfe-release-bot
Copy link

✅   DCO Check Passed

@stockholmux
Copy link
Member Author

All comments should be addressed - thanks for the review, folks.

@CEHENKLE CEHENKLE merged commit a7776b7 into opensearch-project:main Mar 19, 2021
@stockholmux stockholmux deleted the testing-doc branch March 24, 2021 17:29
ritty27 pushed a commit to ritty27/OpenSearch that referenced this pull request May 12, 2024
@dependabot
Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156 (opensea…
0fb1068 
…rch-project#390)

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.154 to 4.8.156.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.154...classgraph-4.8.156)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
ritty27 pushed a commit to ritty27/OpenSearch that referenced this pull request May 12, 2024
@MarinaRazumovsky @VachaShah
@iamdanhart @andrross @reta @AmiStrn @szczepanczykd @dblock @dependabot @gaiksaya @L00kian @luneo7
Add option to set headers and sort options in cat requests (opensearc…
938170a 
…h-project#412)

* Adding x-amz-content-sha256 header for signed requests (opensearch-project#339)

* Adding X-Amz-Content-Sha256 header for signed requests

Signed-off-by: Vacha Shah <[email protected]>

* Adding CHANGELOG entry

Signed-off-by: Vacha Shah <[email protected]>

* Adding documentation comment

Signed-off-by: Vacha Shah <[email protected]>

* Adding tests

Signed-off-by: Vacha Shah <[email protected]>

* Addressing comments

Signed-off-by: Vacha Shah <[email protected]>

* Addressing comments

Signed-off-by: Vacha Shah <[email protected]>

* Removing refresh policy for integ tests for Sigv4

Signed-off-by: Vacha Shah <[email protected]>

* Updating the developer guide

Signed-off-by: Vacha Shah <[email protected]>

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fix issue with completion suggester being parsed as term suggester. (opensearch-project#347)

* Fix issue with completion suggester being parsed as term suggester.

This commit fixes the issue where a completion suggester search request
was being parsed as a term suggester and failing due to "Missing
required property 'TermSuggestOption.score'"

This solution was originally proposed by Github user @apatrida

Signed-off-by: Dan Hart <[email protected]>

* Remove commented code

Signed-off-by: Dan Hart <[email protected]>

* Fix format of changelog item

Signed-off-by: Dan Hart <[email protected]>

Signed-off-by: Dan Hart <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Update USER_GUIDE to use exact AWS brand names (opensearch-project#352)

Minor update to use exact brand names. "OpenSearch" is rather overloaded
to I find it less confusing to be precise in the naming.

Signed-off-by: Andrew Ross <[email protected]>

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bumps Jackson from 2.14.1 to 2.14.2 (opensearch-project#357)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bulk UpdateOperation misses upsert options (opensearch-project#353)

* Bulk UpdateOperation misses upsert options

Signed-off-by: Andriy Redko <[email protected]>

* Fix formatting

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Upgrading compatibility to opensearch 2.5 (opensearch-project#367)

* Upgrading compatibility to opensearch 2.5

Signed-off-by: amitai stern <[email protected]>

* latest 2.4 version

Signed-off-by: amitai stern <[email protected]>

* keep existing compatibility matrix rows, this pr adds a new row for versions of opensearch after 2.3.0

Signed-off-by: amitai stern <[email protected]>

---------

Signed-off-by: amitai stern <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* add option to set columns into cat indices request

Signed-off-by: MarinaRazumovsky <[email protected]>

* add changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* changes in CatRequestBase, IndicesRequest, NodesRequest, RecoveryRequest and add tests

Signed-off-by: MarinaRazumovsky <[email protected]>

* Feature/range aggregation fix 369 (opensearch-project#370)

* test: create integration tests for date_range and range aggregation (opensearch-project#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

* fix: add a missing key propery to the RangeBucket (opensearch-project#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

* docs: add CHANGELOG entry (opensearch-project#369)

Signed-off-by: Dominik Szczepanczyk <[email protected]>

---------

Signed-off-by: Dominik Szczepanczyk <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fixing integration tests (opensearch-project#375)

* Fixing integration tests

Signed-off-by: Vacha Shah <[email protected]>

* Updating the test with a non-exact check

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Adding bulk request example in user guide (opensearch-project#373)

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Fixing issue when tracktotalhits is disabled (opensearch-project#372)

* Fixing issue when tracktotalhits is disabled

Signed-off-by: Vacha Shah <[email protected]>

* Update Changelog

Signed-off-by: Vacha Shah <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* changes changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156 (opensearch-project#390)

* Bump io.github.classgraph:classgraph from 4.8.154 to 4.8.156

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.154 to 4.8.156.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.154...classgraph-4.8.156)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add 2PR approval to release workflow (opensearch-project#383)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Adding an example to use raw JSON class instead of target classes (opensearch-project#385)

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Update Gradle to 8.0.2 (opensearch-project#392)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add "mappings" field to IndexSettings object (opensearch-project#382)

Signed-off-by: Ilya Lukyanovich <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Created untriaged issue workflow. (opensearch-project#364)

Signed-off-by: dblock <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 in /java-client (opensearch-project#403)

* Bump io.github.classgraph:classgraph in /java-client

Bumps [io.github.classgraph:classgraph](https://github.com/classgraph/classgraph) from 4.8.156 to 4.8.157.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](classgraph/classgraph@classgraph-4.8.156...classgraph-4.8.157)

---
updated-dependencies:
- dependency-name: io.github.classgraph:classgraph
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Add buffered lookahead for Jackson (opensearch-project#338)

Signed-off-by: luneo7 <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* Mask env values for snapshots (opensearch-project#411)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>

* option to set headers and sort into cat requests

Signed-off-by: MarinaRazumovsky <[email protected]>

* fix test

Signed-off-by: MarinaRazumovsky <[email protected]>

* fix changelog

Signed-off-by: MarinaRazumovsky <[email protected]>

* add cat examples into USER_GUID

Signed-off-by: MarinaRazumovsky <[email protected]>

---------

Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: MarinaRazumovsky <[email protected]>
Signed-off-by: Dan Hart <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: amitai stern <[email protected]>
Signed-off-by: Dominik Szczepanczyk <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Ilya Lukyanovich <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: luneo7 <[email protected]>
Co-authored-by: Vacha Shah <[email protected]>
Co-authored-by: Danny Hart <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
Co-authored-by: amitai stern <[email protected]>
Co-authored-by: szczepanczykd <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sayali Gaikawad <[email protected]>
Co-authored-by: Ilya Lukyanovich <[email protected]>
Co-authored-by: Lucas Rogerio Caetano Ferreira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlfeng tlfeng tlfeng left review comments

@saratvemulapalli saratvemulapalli saratvemulapalli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stockholmux @odfe-release-bot @saratvemulapalli @tlfeng @CEHENKLE