Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Fix gradle build as part of the renaming process. #397

Merged
merged 5 commits into from
Mar 18, 2021
Merged

[Rename] Fix gradle build as part of the renaming process. #397

merged 5 commits into from
Mar 18, 2021

Conversation

adnapibar
Copy link
Contributor

Relates #160

Currently the gradle build is not working and this commit tries to fix that.

Temporarily comments out the opensearch_distibutions task which seems to be broken at this moment.

Signed-off-by: Rabi Panda [email protected]

@adnapibar adnapibar added >FORK Related to the fork process Rename Renaming to OpenSearch labels Mar 18, 2021
@odfe-release-bot
Copy link

✅   DCO Check Passed

1 similar comment
@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Left some comments and questions for others feedback that we should close on before merging.

build.gradle Show resolved Hide resolved
client/rest/build.gradle Show resolved Hide resolved
client/sniffer/build.gradle Show resolved Hide resolved
distribution/docker/build.gradle Outdated Show resolved Hide resolved
gradle/local-distribution.gradle Outdated Show resolved Hide resolved
modules/reindex/build.gradle Outdated Show resolved Hide resolved
qa/remote-clusters/build.gradle Show resolved Hide resolved
qa/wildfly/build.gradle Show resolved Hide resolved
server/build.gradle Show resolved Hide resolved
test/framework/build.gradle Show resolved Hide resolved
@odfe-release-bot
Copy link

✅   DCO Check Passed

This commit comments out the `opensearch_distibutions` task which seems to be broken at this moment.

Signed-off-by: Rabi Panda <[email protected]>
- uncomment task in builds for which it's not failing
- add issue url to the builds for which the task is failing

Signed-off-by: Rabi Panda <[email protected]>
@adnapibar adnapibar requested a review from nknize March 18, 2021 22:08
@odfe-release-bot
Copy link

✅   DCO Check Passed

Signed-off-by: Rabi Panda <[email protected]>
@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanx! LGTM!

@adnapibar adnapibar merged commit f7645c0 into opensearch-project:rename/opensearch Mar 18, 2021
@adnapibar adnapibar deleted the rename/opensearch/fix-gradle-build branch March 18, 2021 23:14
nknize pushed a commit that referenced this pull request Mar 20, 2021
This commit fixes the currently broken gradle build resulted from the renaming work. It reverts a few dependencies and comments out the `opensearch_distibutions` task which is currently failing for some builds. We will address these separately in the future once we have a working build.

Signed-off-by: Rabi Panda <[email protected]>
nknize pushed a commit that referenced this pull request Mar 22, 2021
This commit fixes the currently broken gradle build resulted from the renaming work. It reverts a few dependencies and comments out the `opensearch_distibutions` task which is currently failing for some builds. We will address these separately in the future once we have a working build.

Signed-off-by: Rabi Panda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>FORK Related to the fork process Rename Renaming to OpenSearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants