Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rename] org.opensearch.transport.netty4.OpenSearchLoggingHandlerIT.testLoggingHandler #461

Merged
merged 2 commits into from
Mar 25, 2021
Merged

[Rename] org.opensearch.transport.netty4.OpenSearchLoggingHandlerIT.testLoggingHandler #461

merged 2 commits into from
Mar 25, 2021

Conversation

harold-wang
Copy link
Contributor

Description

[Describe what this change achieves]
Changed ESLoggingHandler to OpenSearchLoggingHandler

Issues Resolved

[List any issues this PR will resolve]
#441

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Signed-off-by: Harold Wang [email protected]

@harold-wang harold-wang self-assigned this Mar 25, 2021
@harold-wang harold-wang added Rename Renaming to OpenSearch :test Adding or fixing a test >FORK Related to the fork process labels Mar 25, 2021
@harold-wang harold-wang mentioned this pull request Mar 25, 2021
Closed
77 tasks
@odfe-release-bot
Copy link

✅   DCO Check Passed bf1504488a1d5bd47505678ff8efc93b55c4fc08

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success bf1504488a1d5bd47505678ff8efc93b55c4fc08

@odfe-release-bot
Copy link

✅   Gradle Precommit success bf1504488a1d5bd47505678ff8efc93b55c4fc08

adnapibar
adnapibar approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@odfe-release-bot
Copy link

❌   DCO Check Failed 2905cee3ce5d439a29bc4ff79a397abd787eafa8
Run ./dev-tools/signoff-check.sh remotes/origin/main 2905cee3ce5d439a29bc4ff79a397abd787eafa8 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success 2905cee3ce5d439a29bc4ff79a397abd787eafa8

@odfe-release-bot
Copy link

✅   Gradle Precommit success 2905cee3ce5d439a29bc4ff79a397abd787eafa8

@harold-wang
Change ESLoggingHandler to OpenSearchLoggingHandler to pass failing t…
1814b2d 
…est case org.opensearch.transport.netty4.OpenSearchLoggingHandlerIT.testLoggingHandler due to renaming

Signed-off-by: Harold Wang <[email protected]>
@odfe-release-bot
Copy link

✅   DCO Check Passed 1814b2d

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success 1814b2d

@odfe-release-bot
Copy link

✅   Gradle Precommit success 1814b2d

@odfe-release-bot
Copy link

❌   DCO Check Failed a3fcb0dada74748aa3ce21dcd31a77770c13e433
Run ./dev-tools/signoff-check.sh remotes/origin/main a3fcb0dada74748aa3ce21dcd31a77770c13e433 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success a3fcb0dada74748aa3ce21dcd31a77770c13e433

@odfe-release-bot
Copy link

✅   Gradle Precommit success a3fcb0dada74748aa3ce21dcd31a77770c13e433

@odfe-release-bot
Copy link

✅   DCO Check Passed bea680b

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success bea680b

@odfe-release-bot
Copy link

✅   Gradle Precommit success bea680b

@harold-wang harold-wang merged commit 58dbb59 into opensearch-project:main Mar 25, 2021
@harold-wang harold-wang deleted the testLoggingHandler branch April 12, 2021 17:13
ritty27 pushed a commit to ritty27/OpenSearch that referenced this pull request May 12, 2024
@harshavamsi @reta
Adds point in time APIs (opensearch-project#461)
4ceb43b 
* Adds point in time APIs

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Add version check for Point in time tests

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update point in time namespace

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update point in time to pit everywhere

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update USER_GUIDE.md

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Update USER_GUIDE.md

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Using AssumeTrue for tests for PIT

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

---------

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnapibar adnapibar adnapibar approved these changes

@nknize nknize Awaiting requested review from nknize

@abbashus abbashus Awaiting requested review from abbashus

Assignees

@harold-wang harold-wang

Labels
>FORK Related to the fork process Rename Renaming to OpenSearch :test Adding or fixing a test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harold-wang @odfe-release-bot @adnapibar