Make :server:check pass successfully
#471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PluginsServiceTests uses couple of dummy plugin jars from the resources directory. The jars have classes with imports with package name `org.elasticsearch.*`. This commit recreates the jars after renaming those package names. Signed-off-by: Rabi Panda <[email protected]>
As we changed the metadata prefix in OpenSearchException from `es.` to `opensearch.` (commit 13f6d23), the order of the keys in the HashMap changed (HashMap does not guarantee a order). However, the tests are expecting a value which relies on a certain order . Ideally, these tests should not assume the order. This commit doesn't rewrite the test but only changes the order so the tests pass. Signed-off-by: Rabi Panda <[email protected]>
As part of the commit 0bdd129, we renamed the data examples in used in the test cases. This caused the test failures in SimpleNestedIT as it was sorting the results and the rename changed the order of the search result. In SearchQueryIT, we missed to rename the term used in the query. This commit fixes both the issues. Signed-off-by: Rabi Panda <[email protected]>
adnapibar
added
>FORK
|
✅ DCO Check Passed 1f135e9 |
|
✅ Gradle Wrapper Validation success 1f135e9 |
|
✅ Gradle Precommit success 1f135e9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the renaming work #160, a few tests are failing for
./gradlew :server:check.The
PluginsServiceTestsuses a couple of dummy plugin jars which are in the test/resources directory. The jars have classes with importsorg.elasticsearch.*.This is fixed in this PR by recreating the jars after renaming those imports.
As we changed the metadata prefix in
OpenSearchExceptionfromes.toopensearch.(commit 13f6d23), the order of the keys in theHashMapchanged. However, the tests are expecting a value which relies on a certain order . Ideally, these tests should not assume the order as there is no guarantee provided byHashMap.This is fixed in this PR by only changing the order of expected result so the tests pass.
In #454 we renamed the example data used in tests - this caused a few tests to fail
In this PR, we fix those renaming issues.
Issues Resolved
Issues mentioned in #441
Check List
[ ] New functionality includes testing.[ ] All tests pass[ ] New functionality has been documented.[ ] New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Rabi Panda [email protected]