-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Add connectToNodeAsExtension in TransportService #7346
[Backport 2.x] Add connectToNodeAsExtension in TransportService #7346
Conversation
…6866) * Add connectToNodeAsExtension in TransportService Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Update java docstrings Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit b752555)
Signed-off-by: Craig Perkins <[email protected]>
CHANGELOG.md
Outdated
- [Remote Store] Integrate remote segment store in peer recovery flow ([#6664](https://github.com/opensearch-project/OpenSearch/pull/6664)) | ||
- [Segment Replication] Add new cluster setting to set replication strategy by default for all indices in cluster. ([#6791](https://github.com/opensearch-project/OpenSearch/pull/6791)) | ||
- Enable sort optimization for all NumericTypes ([#6464](https://github.com/opensearch-project/OpenSearch/pull/6464) | ||
- Remove 'cluster_manager' role attachment when using 'node.master' deprecated setting ([#6331](https://github.com/opensearch-project/OpenSearch/pull/6331)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding these changes to CHANGELOG? They have already been released in 2.7.
Just the below change should be enough for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think this was missed during the review of #6866 . Since we are backporting it to 2.x and it will be released in 2.8 we don't need to add the CHANGELOG entry under unreleased 3.x but rather unreleased 2.x. This was the reason of the failed backport workflow. I would suggest to raise another PR on main and add the change under 2.x and remove it from 3.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, I used the merge conflict tool on github when resolving the conflict. I'm not sure how all of the other items got included.
Signed-off-by: Craig Perkins <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #7346 +/- ##
============================================
+ Coverage 70.37% 70.38% +0.01%
+ Complexity 59731 59728 -3
============================================
Files 4850 4850
Lines 287193 287212 +19
Branches 41727 41728 +1
============================================
+ Hits 202104 202147 +43
+ Misses 68177 68147 -30
- Partials 16912 16918 +6
|
Backport #6866 to 2.x