Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BWC checks #796

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Enable BWC checks #796

merged 1 commit into from
Jun 3, 2021

Conversation

adnapibar
Copy link
Contributor

@adnapibar adnapibar commented May 28, 2021

Description

This PR enables the BWC checks in OpenSearch. The existing issues were fixed by the following PRs

Issues Resolved

The following issues can be resolved.

Check List

- [ ] New functionality includes testing.

  • All tests pass
    - [ ] New functionality has been documented.
    - [ ] New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rabi Panda [email protected]

@adnapibar adnapibar added :test Adding or fixing a test backwards-compatibility labels May 28, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed e0017bfe87c87b9b09c9059a1d09b2633622a257

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success e0017bfe87c87b9b09c9059a1d09b2633622a257

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success e0017bfe87c87b9b09c9059a1d09b2633622a257

build.gradle Show resolved Hide resolved
Copy link
Contributor

@harold-wang harold-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks Rabi!

@adnapibar
Copy link
Contributor Author

Waiting on #797 to be merged before starting gradle check and subsequently merging it.

@dblock
Copy link
Member

dblock commented Jun 3, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure e0017bfe87c87b9b09c9059a1d09b2633622a257
Log 220

Reports 220

Signed-off-by: Rabi Panda <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 194c8ae

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 194c8ae

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 194c8ae

@adnapibar
Copy link
Contributor Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 194c8ae
Log 221

Reports 221

@dblock
Copy link
Member

dblock commented Jun 3, 2021

@adnapibar Sounds like a merge to me!

@adnapibar adnapibar merged commit 33708d2 into opensearch-project:main Jun 3, 2021
@dblock dblock mentioned this pull request Jun 3, 2021
@adnapibar adnapibar mentioned this pull request Jun 3, 2021
1 task
dblock pushed a commit that referenced this pull request Jun 3, 2021
nknize pushed a commit that referenced this pull request Jun 25, 2021
@adnapibar adnapibar deleted the enable_bwc branch November 15, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-compatibility :test Adding or fixing a test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants