-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SegmentReplication flaky integ tests #8134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8134 +/- ##
============================================
+ Coverage 70.98% 71.06% +0.07%
- Complexity 56687 56737 +50
============================================
Files 4722 4722
Lines 267608 267619 +11
Branches 39216 39218 +2
============================================
+ Hits 189973 190172 +199
+ Misses 61582 61463 -119
+ Partials 16053 15984 -69
|
Signed-off-by: Sachin Kale <[email protected]>
sachinpkale
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
dbwiddis
as code owners
June 20, 2023 13:56
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
mch2
reviewed
Jun 20, 2023
...er/src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/shard/IndexShard.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/shard/RemoteStoreRefreshListenerTests.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/shard/IndexShard.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sachin Kale <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
mch2
approved these changes
Jun 23, 2023
...er/src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
Show resolved
Hide resolved
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
Signed-off-by: Sachin Kale <[email protected]> (cherry picked from commit 0c7ba94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
imRishN
pushed a commit
to imRishN/OpenSearch
that referenced
this pull request
Jun 27, 2023
Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Rishab Nahata <[email protected]>
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Jun 27, 2023
Signed-off-by: Sachin Kale <[email protected]>
sudarshan-baliga
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Jun 29, 2023
Signed-off-by: Sachin Kale <[email protected]>
sachinpkale
pushed a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Jul 4, 2023
Signed-off-by: Sachin Kale <[email protected]> (cherry picked from commit 0c7ba94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale
pushed a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Jul 5, 2023
Signed-off-by: Sachin Kale <[email protected]> (cherry picked from commit 0c7ba94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale
pushed a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Jul 10, 2023
Signed-off-by: Sachin Kale <[email protected]> (cherry picked from commit 0c7ba94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale
pushed a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Sachin Kale <[email protected]> (cherry picked from commit 0c7ba94) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna
pushed a commit
that referenced
this pull request
Jul 11, 2023
(cherry picked from commit 0c7ba94) Signed-off-by: Sachin Kale <[email protected]>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 29, 2023
Signed-off-by: Sachin Kale <[email protected]>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getLatestSegmentInfosAndCheckpoint
method is eventually invoked and failing with the call togetEngine().config().getCodec().getName()
because the engine is already closed. The method already has logic to return empty if the shard is not open, but it is shut after this check. So we need to ensure the shard is not closed while this method is invoked or if we don't want to block shard close for this catch the error and gracefully return.SegmentReplicationIT
are flaky. This was observed while debugging flakiness inSegmentReplicationRemoteStoreIT
which extends SegmentReplicationIT with remote store settings.Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.