[Bug] Fix Setting#byteSizeSetting to use whole value string

[nknize]

This fixes a bug where the Setting#byteSizeSetting static method returned fractional byte values when calling .toString inside the lambda. The change is to directly return the bytes value as a string instead of using ByteSizeValue#toString which tries to be smart and pretty print in a more human-friendly format.

closes #9010
relates #9005

[nknize]

This is currently blocking passing builds on main.

[nknize]

@reta mind giving this a quick once over and approval so we can unblock test failures?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=cluster.allocation_explain/10_basic/cluster shard allocation explanation test with empty request}

• URL: https://build.ci.opensearch.org/job/gradle-check/21495/
• CommitID: 2e64d34
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #9011 (994479b) into main (35662f0) will increase coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #9011      +/-   ##
============================================
+ Coverage     71.02%   71.05%   +0.03%     
- Complexity    57210    57268      +58     
============================================
  Files          4764     4764              
  Lines        270156   270153       -3     
  Branches      39532    39532              
============================================
+ Hits         191887   191967      +80     
+ Misses        62100    62056      -44     
+ Partials      16169    16130      -39     

Files Changed	Coverage Δ
...n/java/org/opensearch/common/settings/Setting.java	85.87% <100.00%> (ø)
...java/org/opensearch/common/unit/ByteSizeValue.java	99.08% <100.00%> (+0.86%)	⬆️

... and 442 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=cluster.allocation_explain/10_basic/cluster shard allocation explanation test with empty request}

• URL: https://build.ci.opensearch.org/job/gradle-check/21496/
• CommitID: 994479b
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[nknize]

I'm going to go ahead and YOLO merge this to unblock the failures on main.

[dbwiddis]

@nknize was about to say LGTM except for change log.

Can you add a change log entry in your next commit?

[dbwiddis]

Or I see skip-changelog was specifically added.... okay...

[nknize]

Or I see skip-changelog was specifically added.... okay...

Yeah.. This changelog mechanism is pretty broken. 😕 I can go back and add an entry for this if you think it's really needed.